[Yaml] deprecate the Dumper::setIndentation() method #17746
Conversation
xabbuh
commented
Feb 9, 2016
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | yes |
| Tests pass? | yes |
| Fixed tickets | |
| License | MIT |
| Doc PR |
| @@ -24,6 +24,9 @@ Serializer | |||
| Yaml | |||
| ---- | |||
|
|
|||
| * The `Dumper::setIndentation()` method was removed. Pass the indentation | |||
| level to the constructor instead. | |||
There was a problem hiding this comment.
Technically the method was not removed yet.
There was a problem hiding this comment.
Technically, you are right (I forgot to reply to your comment on your PR last week, sorry for that). But I think we should keep the upgrade files in sync (we did the same during the development of the 2.x versions with the UPGRADE-3.0.md file). Otherwise we would need to spend a lot of time on syncing the files when the development of 4.0 starts.
There was a problem hiding this comment.
I'm only worried that we document that something was removed in UPGRADE-4.0.md file, but then we forget to remove it.
There was a problem hiding this comment.
well, forgetting to remove deprecated APIs would be a failure in our process anyway
There was a problem hiding this comment.
Fair enough.
I documented the change mentioned by xabbuh here: #17753.
|
Thank you @xabbuh. |
…xabbuh) This PR was merged into the 3.1-dev branch. Discussion ---------- [Yaml] deprecate the Dumper::setIndentation() method | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | Commits ------- de4b207 deprecate the Dumper::setIndentation() method