[DomCrawler] Clarify the value returned by getPhpFiles() #17776
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
41a820a to
d6fabcd
Compare
| @@ -157,8 +157,12 @@ public function getPhpValues() | |||
| * | |||
| * This method converts fields with the array notation | |||
| * (like foo[bar] to arrays) like PHP does. | |||
| * The returned array is consistent with the array for field values | |||
| * (@see getPhpValues), rather then uploaded files found in $_FILES. | |||
There was a problem hiding this comment.
rather then -> rather than
The comment was previously suggesting the returned value is similar to the one stored in $_FILES, while it is more similar to the way PHP stores submitted form values. It is actually more convenient to have it this way, so rather then changing the returned value (which would break BC), it is better to clarify the comment.
d6fabcd to
a694401
Compare
|
Thank you @jakzal. |
fabpot
added a commit
that referenced
this pull request
Feb 12, 2016
… (jakzal) This PR was merged into the 2.3 branch. Discussion ---------- [DomCrawler] Clarify the value returned by getPhpFiles() | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #14021 | License | MIT | Doc PR | - The comment was previously suggesting the returned value is similar to the one stored in $_FILES, while it is more similar to the way PHP stores submitted form values. It is actually more convenient to have it this way, so rather then changing the returned value (which would break BC), it is better to clarify the comment. Commits ------- a694401 [DomCrawler] Clarify the value returned by getPhpFiles()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The comment was previously suggesting the returned value is similar to the one stored in $_FILES, while it is more similar to the way PHP stores submitted form values. It is actually more convenient to have it this way, so rather then changing the returned value (which would break BC), it is better to clarify the comment.