[BrowserKit] Fixed incorrect temp dir when running insulated functional tests in Windows #1785
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…al tests under Windows
fabpot
added a commit
that referenced
this pull request
Jul 24, 2011
Commits ------- bd9af2b [BrowserKit] Fixed incorrect temp dir when running insulated functional tests under Windows Discussion ---------- [BrowserKit] Fixed incorrect temp dir when running insulated functional tests in Windows The `Client` class in the `BrowserKit`-component does not pass on a temporary directory environment variable recognized by Windows. This can lead to an incorrect temp dir being used when using an insulated `Client` in a functional test. A fix for Mac was already present, I extended this to also work on Windows.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Clientclass in theBrowserKit-component does not pass on a temporary directory environment variable recognized by Windows. This can lead to an incorrect temp dir being used when using an insulatedClientin a functional test. A fix for Mac was already present, I extended this to also work on Windows.