Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[HttpFoundation] Fix BC break introduced by #17642 #18006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[HttpFoundation] Fix BC break introduced by #17642 #18006

wants to merge 2 commits into from

Conversation

dunglas
Copy link
Member

@dunglas dunglas commented Mar 4, 2016

Q A
Branch master
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #17642
License MIT
Doc PR n/a

@taylorotwell can you confirm it fixes the issue with Laravel?

@fabpot
Copy link
Member

fabpot commented Mar 4, 2016

LGTM

@nicolas-grekas
Copy link
Member

You also need to update the UPGRADE and Controller.php files that where modified in #17642, isn't it?

@dunglas
Copy link
Member Author

dunglas commented Mar 4, 2016

@nicolas-grekas, I don't think so. Controller.php only use the constructor and it's signature hasn't been modified and CHANGELOG files are still accurate.

@fabpot
Copy link
Member

fabpot commented Mar 4, 2016

Thank you @dunglas.

@fabpot fabpot closed this in 1330662 Mar 4, 2016
@dunglas dunglas deleted the fix_bc_17642 branch March 4, 2016 09:14
@fabpot fabpot mentioned this pull request May 13, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
HttpFoundation Status: Needs Work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dunglas @fabpot @nicolas-grekas @carsonbot