[HttpFoundation] Fix the build on windows (with mbstring extension missing) #18029
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hm.. the issue is not fully fixed just yet. Before the build was failing with two errors: With this PR it only fails with the second one. @xabbuh I'm not sure why it was earlier implemented with a loop through all the characters. Perhaps you could give some more insights? |
|
Any reason not to use https://github.com/symfony/polyfill-mbstring as it provides a polyfill for the mb functions used here? |
|
@wouterj that's an option indeed |
A file with non-ascii characters in the name needs to be created from PHP in order for it to be read properly on all platforms.
|
Tests fixed. Just bare in mind this is an alternative to #18030. status: needs review |
|
Actually, this will only work with unicode, while the existing solution supports all available encodings. |
nicolas-grekas
added a commit
that referenced
this pull request
Mar 7, 2016
…ll (jakzal) This PR was squashed before being merged into the 2.3 branch (closes #18030). Discussion ---------- [HttpFoundation] Add a dependency on the mbstring polyfill | Q | A | ------------- | --- | Branch | 2.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? |no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Alternative for #18029. Commits ------- 59b9f15 [HttpFoundation] Add a dependency on the mbstring polyfill
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An alternative approach to #16656 that works without the mbstring extension. If we tried to follow the current approach and make it work without mbstring it would make code quite more complex.