[DoctrineBridge] deprecate MergeDoctrineCollectionListener::onBind()
#18069
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
HeahDude
commented
Mar 9, 2016
| Q | A |
|---|---|
| Branch | master |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | yes |
| Tests pass? | yes |
| Fixed tickets | n/a |
| License | MIT |
| Doc PR | - |
|
But this is a BC break, isn't it? The listener will not execute the <?php
class MyMergeDoctrineCollectionListener extends MergeDoctrineCollectionListener
{
public function onBind()
{
// my own implementation
}
} |
|
@dosten Indeed. Have to keep the old method in the |
28dbfe4 to
2819bfd
Compare
|
Ok now 37cdb80 fixes the BC break and adds some tests. |
2819bfd to
37cdb80
Compare
37cdb80 to
6eb3873
Compare
|
What's the status of this one ? |
| { | ||
| // If onBind() is overridden then logic has been executed | ||
| if ($this->bc) { |
There was a problem hiding this comment.
Not sure if that is sufficient. Someone who overrode the onBind() method will likely also have added a call to parent::onBind().
There was a problem hiding this comment.
Nice catch! Thanks, now fixed by https://github.com/symfony/symfony/pull/18069/files#diff-0bab777c646233bc954aa7792bc59d30R73
6eb3873 to
2e4fdfe
Compare
| */ | ||
| public function onBind() | ||
| { | ||
| if (self::class === __CLASS__) { |
There was a problem hiding this comment.
this will always be true, as self::class does not use late static binding
There was a problem hiding this comment.
I could use get_class($this) then.
2e4fdfe to
08a7a09
Compare
|
@stof Fixed, thanks. |
|
ping :) |
| * added "{{ value }}" message placeholder to UniqueEntityValidator | ||
| * added "{{ value }}" message placeholder to UniqueEntityValidator | ||
| * deprecated `MergeDoctrineCollectionListener::onBind` in favor of | ||
| `MergeDoctrineListener::onSubmit` |
There was a problem hiding this comment.
Shouldn't it be MergeDoctrineCollectionListener::onSubmit?
|
Apart from the typo, 👍 |
08a7a09 to
ad08b95
Compare
|
Fixed! Thanks. |
|
Thank you @HeahDude. |
fabpot
added a commit
that referenced
this pull request
Apr 28, 2016
…tener::onBind()` (HeahDude) This PR was merged into the 3.1-dev branch. Discussion ---------- [DoctrineBridge] deprecate `MergeDoctrineCollectionListener::onBind()` | Q | A | ------------- | --- | Branch | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | - Commits ------- ad08b95 [DoctrineBridge] deprecated `MergeDoctrineCollectionListener::onBind()`
HeahDude
added a commit
to HeahDude/symfony
that referenced
this pull request
Apr 29, 2016
HeahDude
added a commit
to HeahDude/symfony
that referenced
this pull request
Apr 30, 2016
HeahDude
added a commit
to HeahDude/symfony
that referenced
this pull request
May 3, 2016
HeahDude
added a commit
to HeahDude/symfony
that referenced
this pull request
May 3, 2016
fabpot
added a commit
that referenced
this pull request
May 11, 2016
This PR was merged into the 3.1-dev branch. Discussion ---------- [DoctrineBridge] Fixed bc layer after #18069 | Q | A | ------------- | --- | Branch? | master | Bug fix? | BC break | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | ~ | License | MIT | Doc PR | ~ Commits ------- 8a6cf9d [DoctrineBridge] fixed bc layer from #18069
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.