[Form] Fix INT64 cast to float in IntegerType. #18077
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ovrflo this change broke tests on windows, most likely because it's run on 32bit system. |
|
@jakzal thanks for noticing :) I added a fix that will make the tests pass. I mean, my last commit will revert to the old behaviour for 32-bit PHP, but that's not really a fix, is it ? Another way to do it would be to check with strlen for big numbers on 32-bit and decide between INT32 and INT64 (for INT64 it will be casted to float). // I'm starting to understand why doctrine refuses to cast my BIGINT columns to PHP's int :) So, what now ? |
|
@nicolas-grekas Do you have any input here? |
nicolas-grekas
added a commit
that referenced
this pull request
Mar 15, 2016
…sform with big integers (ovrflo, nicolas-grekas) This PR was merged into the 2.3 branch. Discussion ---------- [Form] Fix NumberToLocalizedStringTransformer::reverseTransform with big integers | Q | A | ------------- | --- | Branch | 2.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #18077, #18067 | License | MIT | Doc PR | - Commits ------- 03c008c [Form] Fix NumberToLocalizedStringTransformer::reverseTransform with big integers 6b6073f [Form] Fix INT64 cast to float in IntegerType.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This is my fix for #18067. I also added a test for this bug.
Thanks !