[HttpFoundation] Add support for sending raw cookies in the response #18105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jakzal
commented
Mar 11, 2016
| Q | A |
|---|---|
| Branch | master |
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #13646 |
| License | MIT |
| Doc PR | symfony/symfony-docs#6436 |
| @@ -151,4 +151,13 @@ public function testToString() | |||
| $cookie = new Cookie('foo', 'bar', 0, '/', ''); | |||
| $this->assertEquals('foo=bar; path=/; httponly', $cookie->__toString()); | |||
| } | |||
|
|
|||
| public function testRawCookie() | |||
There was a problem hiding this comment.
Should we also add a test which creates a raw cookie for a request and then check if its contents are really not encoded?
There was a problem hiding this comment.
I don't know the way to capture headers in a test. Do you have an idea how to do it?
There was a problem hiding this comment.
I'd say you can't. We'd need a functional test.
|
👍 |
|
👍 |
|
Thank you @jakzal. |
fabpot
added a commit
that referenced
this pull request
Mar 15, 2016
…n the response (jakzal) This PR was merged into the 3.1-dev branch. Discussion ---------- [HttpFoundation] Add support for sending raw cookies in the response | Q | A | ------------- | --- | Branch | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #13646 | License | MIT | Doc PR | TODO Commits ------- 43760a6 [HttpFoundation] Add support for sending raw cookies in the response
Merged
|
Can this be merged to lower versions? 2.8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.