[FrameworkBundle] Replace kernel.debug with member variable #18139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
LGTM 👍 |
Member
|
Thank you @patrick-mcdougle. |
fabpot
added a commit
that referenced
this pull request
Mar 15, 2016
…ble (patrick-mcdougle) This PR was merged into the 2.7 branch. Discussion ---------- [FrameworkBundle] Replace kernel.debug with member variable | Q | A | ------------- | --- | Branch | 2.7 | Bug fix? | no | New feature? | no | BC breaks? | unlikely | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a While digging around I noticed that someone added debug to the constructor, but didn't replace all the `%kernel.debug%` strings. This PR is just to improve consistency. Technically this could cause a BC break if someone was using a compiler pass to alter the argument of the constructor while the other config was relying on `%kernel.debug%`, but the likelihood of that is probably very low. Commits ------- 181f256 Use debug member variable
Contributor
Author
|
Noob question: Does this get merged into the more current branches too? 2.8, 3, master? |
Member
|
@patrick-mcdougle yes! From time to time, maintainers merge branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While digging around I noticed that someone added debug to the constructor, but didn't replace all the
%kernel.debug%strings. This PR is just to improve consistency.Technically this could cause a BC break if someone was using a compiler pass to alter the argument of the constructor while the other config was relying on
%kernel.debug%, but the likelihood of that is probably very low.