[Cache] Add a Chain adapter #18215
Merged
[Cache] Add a Chain adapter #18215
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fabbot failure is a false positive (and a fabbot bug) |
| use Psr\Cache\CacheItemPoolInterface; | ||
|
|
||
| /** | ||
| * Marker interface for adapters managing {@see \Symfony\Component\Cache\CacheItem} instances. |
There was a problem hiding this comment.
I can't understand this description:
Marker interface for adapters managing instances.
f270645 to
affe749
Compare
affe749 to
68d9cea
Compare
|
|
||
| if ($item->isHit()) { | ||
| while (0 <= --$i) { | ||
| $saveUp($this->adapters[$i], $item); |
There was a problem hiding this comment.
@nicolas-grekas I don't understand why you save the item with a new lifetime for a fetch operation. Can you explain it to me plz ?
There was a problem hiding this comment.
because there is no way to know the remaining lifetime of the item in its original pool...
|
ping @symfony/deciders |
|
👍 |
|
|
||
| /** | ||
| * @param CacheItemPoolInterface[] $adapters The ordered list of adapters used to fetch cached items. | ||
| * @param int $maxLifetime The max lifetime of items propagated from lower adapters to upper ones. |
There was a problem hiding this comment.
dots at the end of @param lines should be removed
|
👍 |
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Mar 27, 2016
This PR was merged into the 3.1-dev branch. Discussion ---------- [Cache] Add a Chain adapter | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | no | Fixed tickets | #17556 | License | MIT | Doc PR | - Made in coordination with @dunglas Commits ------- 68d9cea [Cache] Optimize Chain adapter ebdcd16 [Cache] Add a Chain adapter
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made in coordination with @dunglas