Don't send default cache header for 301 redirects #18220

e-moe · 2016-03-17T16:01:28Z

Q	A
Branch?	"master"
Bug fix?	no
New feature?	yes
BC breaks?	yes
Deprecations?	no
Tests pass?	yes
Fixed tickets	#17139
License	MIT
Doc PR	see comments from #17139

e-moe · 2016-03-17T16:02:15Z

src/Symfony/Component/HttpFoundation/RedirectResponse.php

@@ -41,6 +41,10 @@ public function __construct($url, $status = 302, $headers = array())
        if (!$this->isRedirect()) {
            throw new \InvalidArgumentException(sprintf('The HTTP status code is not a redirect ("%s" given).', $status));
        }
+
+        if (301 == $status && !array_key_exists('cache-control', $headers)) {


I'm not sure if it's correct place for this code. Looking forward for review

I would instead move this into the main Response class just before sending the headers to the client.

@fabpot, in Response class headers already computed and contains unnecessary 'no-cache' directive. We can't check wether is was set automatically or explicitly by user. see \Symfony\Component\HttpFoundation\ResponseHeaderBag::computeCacheControlValue

e-moe · 2016-03-18T08:57:51Z

probably we can add $withDefaultCacheControl parameter to \Symfony\Component\HttpFoundation\ResponseHeaderBag::__construct and do something like this:

/**
     * Constructor.
     *
     * @param array $headers An array of HTTP headers
     * @param bool $withDefaultCacheControl
     */
    public function __construct(array $headers = array(), $withDefaultCacheControl = true)
    {
        parent::__construct($headers);

        if ($withDefaultCacheControl && !isset($this->headers['cache-control'])) {
            $this->set('Cache-Control', '');
        }
    }

then, in Response constructor:

$this->headers = new ResponseHeaderBag($headers, 301 != $status); or, even better check against array like $this->headers = new ResponseHeaderBag($headers, in_array($status, self::$useDefaultCacheControl));

fabpot · 2016-06-15T08:34:46Z

I'm going to merge this as is.

fabpot · 2016-06-15T08:34:48Z

Thank you @e-moe.

This PR was merged into the 3.2-dev branch. Discussion ---------- Don't send default cache header for 301 redirects | Q | A | ------------- | --- | Branch? | "master" | Bug fix? | no | New feature? | yes | BC breaks? | yes | Deprecations? | no | Tests pass? | yes | Fixed tickets | #17139 | License | MIT | Doc PR | see comments from #17139 Commits ------- cf253a9 17139: do not send default cache header for 301 redirects

carsonbot added the Status: Needs Review label Mar 17, 2016

e-moe reviewed Mar 17, 2016
View reviewed changes

javiereguiluz changed the title ~~17139: do not send default cache header for 301 redirects~~ Don't send default cache header for 301 redirects Mar 17, 2016

javiereguiluz added Feature BC Break HttpFoundation labels Mar 17, 2016

e-moe force-pushed the ticket_17139 branch from b00c32d to 6db566d Compare March 18, 2016 06:39

17139: do not send default cache header for 301 redirects

cf253a9

e-moe force-pushed the ticket_17139 branch from 6db566d to cf253a9 Compare March 18, 2016 06:56

fabpot merged commit cf253a9 into symfony:master Jun 15, 2016

fabpot mentioned this pull request Oct 27, 2016

Release v3.2.0-BETA1 #20317

Merged

janopae mentioned this pull request Jan 2, 2025

Don't let browsers cache 301 responses forever by default #59346

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Don't send default cache header for 301 redirects #18220

Don't send default cache header for 301 redirects #18220

e-moe commented Mar 17, 2016 •

edited by fabpot

Loading

e-moe Mar 17, 2016

fabpot Mar 18, 2016

e-moe Mar 18, 2016

e-moe commented Mar 18, 2016

fabpot commented Jun 15, 2016

fabpot commented Jun 15, 2016

Don't send default cache header for 301 redirects #18220

Don't send default cache header for 301 redirects #18220

Conversation

e-moe commented Mar 17, 2016 • edited by fabpot Loading

e-moe Mar 17, 2016

Choose a reason for hiding this comment

fabpot Mar 18, 2016

Choose a reason for hiding this comment

e-moe Mar 18, 2016

Choose a reason for hiding this comment

e-moe commented Mar 18, 2016

fabpot commented Jun 15, 2016

fabpot commented Jun 15, 2016

e-moe commented Mar 17, 2016 •

edited by fabpot

Loading