-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[Bridge\PhpUnit] Workaround old phpunit bug, no colors in weak mode, add tests #18272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
nicolas-grekas
commented
Mar 23, 2016
Q | A |
---|---|
Branch? | 2.7 |
Bug fix? | yes |
New feature? | no |
BC breaks? | no |
Deprecations? | no |
Tests pass? | yes |
Fixed tickets | #18222 |
License | MIT |
Doc PR | - |
…weak mode, add tests (nicolas-grekas) This PR was merged into the 2.7 branch. Discussion ---------- [Bridge\PhpUnit] Workaround old phpunit bug, no colors in weak mode, add tests | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #18222 | License | MIT | Doc PR | - Commits ------- 4ea9548 [Bridge\PhpUnit] Workaround old phpunit bug, no colors in weak mode, add tests
Since the 2.8.4 release, I am getting I assume it's related to this issue? Based on the message shown it appears the old classes will be used, not the bug fix. |
…colas-grekas) This PR was merged into the 2.7 branch. Discussion ---------- Exclude Bridge\PhpUnit from composer.json by default | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #18381, #18272 | License | MIT | Doc PR | - Commits ------- 4f90495 Exclude Bridge\PhpUnit from composer.json by default
This would fail if we were using strict mode with php 7, because true is only a valid argument for php < 5.3.6. This was changed from PHP_VERSION_ID >= 50400 ? DEBUG_BACKTRACE_IGNORE_ARGS | DEBUG_BACKTRACE_PROVIDE_OBJECT : true in symfony#18272, but I do not understand why it was simlified, nor why DEBUG_BACKTRACE_IGNORE_ARGS was there at that time.
This would fail if we were using strict mode with php 7, because true is only a valid argument for php < 5.3.6. This was changed from PHP_VERSION_ID >= 50400 ? DEBUG_BACKTRACE_IGNORE_ARGS | DEBUG_BACKTRACE_PROVIDE_OBJECT : true in symfony#18272, but I do not understand why it was simlified, nor why DEBUG_BACKTRACE_IGNORE_ARGS was there at that time.
This would fail if we were using strict mode with php 7, because true is only a valid argument for php < 5.3.6. This was changed from PHP_VERSION_ID >= 50400 ? DEBUG_BACKTRACE_IGNORE_ARGS | DEBUG_BACKTRACE_PROVIDE_OBJECT : true in symfony#18272, but I do not understand why it was simlified, nor why DEBUG_BACKTRACE_IGNORE_ARGS was there at that time.
This would fail if we were using strict mode with php 7, because true is only a valid argument for php < 5.3.6. This was changed from PHP_VERSION_ID >= 50400 ? DEBUG_BACKTRACE_IGNORE_ARGS | DEBUG_BACKTRACE_PROVIDE_OBJECT : true in symfony#18272, but I do not understand why it was simplified, nor why DEBUG_BACKTRACE_IGNORE_ARGS was there at that time.
… (greg0ire) This PR was merged into the 2.8 branch. Discussion ---------- [PhpUnitBridge] Provide debug_backtrace with proper args This would fail if we were using strict mode with php 7, because true is only a valid argument for php < 5.3.6. This was changed from PHP_VERSION_ID >= 50400 ? DEBUG_BACKTRACE_IGNORE_ARGS | DEBUG_BACKTRACE_PROVIDE_OBJECT : true in #18272, but I do not understand why it was simlified, nor why DEBUG_BACKTRACE_IGNORE_ARGS was there at that time. | Q | A | ------------- | --- | Branch? | 2.8 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a Not sure if this qualifies as a bugfix. If not, should I simplify the ternary and target master? My fear is that having the code diverge too much will make it harder to merge subsequent PRs. I know this looks small, but I'm kind of preparing a big PR on the bridge and I'd rather have it smaller and easier to understand by moving everything I can with small patches like this one. Commits ------- 0d826ae Provide debug_backtrace with proper args