ref https://github.com/symfony/symfony/pull/14403/files/f0dfd2faaba4eb7848d3e1b8a7add7da302d8cae#r57138850

Note to merger: to revert in 3.0

Why is the order of the attributes important? Imo you should not rely on it.

@xabbuh we don't have the choice IMHO.

The component themes need to print the value independently from attr so they can be overridden with:

{% set read_only = true %}
{{ block('parent_block') }}

👍 however I think the tests need to be reverted too to ensure that we are fixing the problem (see #14403 (comment))

@mnapoli Thanks for the review, the tests are already reverted (otherwise they would fail).

Failures are unrelated.

You will now need to update the lowest version of the Form component required by the FrameworkBundle to ^2.8.4.

@xabbuh so it should be done in a second commit since this one is supposed to be reverted in 3.0, right ?

Not necessarily if I don't misunderstand you. We need to revert all the changes here in the 3.0 branch, don't we?

Yes we do.

Thanks @xabbuh tests are all green now (excepted appveyor being unusually long).

It seems appveyor has bugged, why does it still try to install icu v51 ?

👍

Status: Reviewed

@xabbuh Do I need to upgrade the composer.json of TwigBridge too ?

@HeahDude Usually you would have to do that. But this time that's not necessary as this was apparently done in another pull request before: https://github.com/symfony/symfony/blob/2.8/src/Symfony/Bridge/Twig/composer.json#L25

@xabbuh Thanks for your leading :)

Thank you @HeahDude.

Thanks @HeahDude for the fix!

@mnapoli Thanks for reporting this issue :)