[Translation] deprecate the backup feature #18290
Conversation
xabbuh
commented
Mar 24, 2016
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | yes |
| Tests pass? | yes |
| Fixed tickets | #16912 (comment) |
| License | MIT |
| Doc PR |
|
@xabbuh @aitboudad what if we remove this backup feature altogether for the Translation component? My feel is that we're trying to do "too much" here. In Symfony we do more "dangerous" things (e.g. the SensioGeneratorBundle) without providing a backup feature. |
|
I agree with @javiereguiluz |
|
I agree too. |
|
I agree too. I'm always disabling this backup, as git already gives me a way to get the old file if something goes wrong, and backup files only lead to mistakes in such cases |
|
I am not too familiar with the Translation component internals. But if you all agree on this, I will revert the new interface and instead deprecate the |
|
@xabbuh I think so and deprecate backup for the |
|
👍 for deprecation |
4fde2f1 to
6c3ddf1
Compare
|
I added deprecation trigger for the backup feature. I couldn't deprecate the |
|
Thank you @xabbuh. |
This PR was merged into the 3.1-dev branch. Discussion ---------- [Translation] deprecate the backup feature | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | #16912 (comment) | License | MIT | Doc PR | Commits ------- 6c3ddf1 [Translation] deprecate the backup feature
…when using "--no-backup" (liarco) This PR was squashed before being merged into the 5.1 branch. Discussion ---------- [FrameworkBundle] Fixing TranslationUpdateCommand failure when using "--no-backup" | Q | A | ------------- | --- | Branch? | 5.1 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | | License | MIT | Doc PR | [5.0.0](https://github.com/symfony/symfony/blob/5.0/src/Symfony/Component/Translation/CHANGELOG.md#500) removed `TranslationWriter::disableBackup()` but `TranslationUpdateCommand` still has `--no-backup` flag. Using that flag throws an error so I think that removing it without deprecation may be the right choice. Thrown error: ``` In TranslationUpdateCommand.php line 287: Attempted to call an undefined method named "disableBackup" of class "Symfony\Component\Translation\Writer\TranslationWriter". ``` Further references to the topic: - #18290 (comment) - #25860 Commits ------- ef24b10 [FrameworkBundle] Fixing TranslationUpdateCommand failure when using "--no-backup"