Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[2.3] fix mocks #18306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 25, 2016
Merged

[2.3] fix mocks #18306

merged 1 commit into from
Mar 25, 2016

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Mar 25, 2016

Q A
Branch? 2.3
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR
  • fix a typo in a method name (setResponse instead of seetResopnse)
  • fix mocking a method that is not part of the DomainObjectInterface

@nicolas-grekas
Copy link
Member

can you please change the cache id so that we verify that this works with latest phpunit-mock-object?

* fix a typo in a method name (`setResponse` instead of `seetResopnse`)
* fix mocking a method that is not part of the `DomainObjectInterface`
@xabbuh
Copy link
Member Author

xabbuh commented Mar 25, 2016

done

@xabbuh xabbuh mentioned this pull request Mar 25, 2016
@xabbuh xabbuh added the Ready label Mar 25, 2016
@stof
Copy link
Member

stof commented Mar 25, 2016

👍

@nicolas-grekas
Copy link
Member

Thank you @xabbuh.

@nicolas-grekas nicolas-grekas merged commit c211523 into symfony:2.3 Mar 25, 2016
nicolas-grekas added a commit that referenced this pull request Mar 25, 2016
This PR was merged into the 2.3 branch.

Discussion
----------

[2.3] fix mocks

| Q             | A
| ------------- | ---
| Branch?       | 2.3
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

* fix a typo in a method name (`setResponse` instead of `seetResopnse`)
* fix mocking a method that is not part of the `DomainObjectInterface`

Commits
-------

c211523 fix mocks
@xabbuh xabbuh deleted the fix-mocks-2.3 branch March 25, 2016 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants