[FrameworkBundle] Fix Templating Engine autowiring #18320
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
dunglas
commented
Mar 26, 2016
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #18242 (comment) |
| License | MIT |
| Doc PR | n/a |
1c70edd to
3facd21
Compare
| @@ -557,6 +562,9 @@ private function registerTemplatingConfiguration(array $config, $ide, ContainerB | |||
| $container->removeDefinition('templating.helper.assets'); | |||
| } | |||
| } | |||
|
|
|||
| $definition = $container->getDefinition($aliased); | |||
There was a problem hiding this comment.
This has to be done in a compiler pass. The templating.engine.twig definition, for example, is registered in the TwigBundle and thus not available here (see the failing test).
|
Status: Needs work |
|
@xabbuh moved to a pass, but CI errors don't look related. Status: needs review |
|
|
||
| class TemplatingPass implements CompilerPassInterface | ||
| { | ||
| public function process(ContainerBuilder $container) | ||
| { | ||
| if ($container->hasAlias('templating')) { | ||
| $alias = $container->getAlias('templating'); | ||
| $definition = $container->getDefinition($alias->__toString()); |
There was a problem hiding this comment.
this can be simplified by using findDefinition('templating')
|
LGTM 👍 |
| use Symfony\Component\DependencyInjection\ContainerBuilder; | ||
| use Symfony\Component\DependencyInjection\Compiler\CompilerPassInterface; | ||
| use Symfony\Component\Templating\EngineInterface; |
There was a problem hiding this comment.
To avoid confusion we could alias this one as ComponentEngineInterface.
|
@xabbuh done |
| @@ -13,7 +13,8 @@ | |||
|
|
|||
| use Doctrine\Common\Annotations\AnnotationReader; | |||
| use Doctrine\Common\Annotations\CachedReader; | |||
| use Symfony\Bundle\FrameworkBundle\Templating\DelegatingEngine; | |||
| use Symfony\Component\Templating\EngineInterface; | |||
There was a problem hiding this comment.
@dunglas Sorry, I think making the same change here too would be good.
|
Thank you @dunglas. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.