[Process] Accept Traversable input #18350
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nicolas-grekas
commented
Mar 29, 2016
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #18262 |
| License | MIT |
| Doc PR | - |
4fb43fb to
c6485ee
Compare
|
|
||
| throw new InvalidArgumentException(sprintf('%s only accepts strings or stream resources.', $caller)); | ||
| throw new InvalidArgumentException(sprintf('%s only accepts strings, Traversable objects or stream resources.', $caller)); |
There was a problem hiding this comment.
technically, your code won't accept Traversable implemented in C without implementing Iterator, or implemented in PHP with IteratorAggregate returning such a traversable.
you should use IteratorIterator instead to wrap any Traversable into an Iterator.
8a72e3d to
5245bed
Compare
| { | ||
| $input = function ($data) { | ||
| while (false !== $data) { | ||
| $data = (yield $data); |
There was a problem hiding this comment.
HHVM doesn't seem to be happy with yield.
5245bed to
b3f382b
Compare
|
HHVM test fixed |
b3f382b to
b9782b7
Compare
|
Sounds very good ! Good job! |
| } | ||
| } | ||
| } | ||
|
|
||
| // no input to read on resource, buffer is empty | ||
| if (null === $this->input && !isset($this->inputBuffer[0])) { | ||
| if (!isset($this->inputBuffer[0]) && !($this->input instanceof \Iterator ? $this->input->valid() : $this->input)) { |
There was a problem hiding this comment.
Why do we use isset() to test for the empty string instead of comparing it with the empty string like we usually do?
There was a problem hiding this comment.
because false is also a possible value here
|
👍 LGTM |
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Mar 31, 2016
This PR was merged into the 3.1-dev branch. Discussion ---------- [Process] Accept Traversable input | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #18262 | License | MIT | Doc PR | - Commits ------- b9782b7 [Process] Accept Traversable input
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.