Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[DX] [LDAP] Added default service name for the Security component's Ldap providers #18387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 1, 2016
Merged

[DX] [LDAP] Added default service name for the Security component's Ldap providers #18387

merged 1 commit into from
Apr 1, 2016

Conversation

csarrazi
Copy link
Contributor

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR

This PR adds a default service name (ldap) for the Security component's Ldap factories (LdapFactory, FormLoginLdapFactory and HttpBasicLdapFactory.

@fabpot
Copy link
Member

fabpot commented Apr 1, 2016

Thank you @csarrazi.

@fabpot fabpot merged commit 29e3d38 into symfony:master Apr 1, 2016
fabpot added a commit that referenced this pull request Apr 1, 2016
…y component's Ldap providers (csarrazi)

This PR was merged into the 3.1-dev branch.

Discussion
----------

[DX] [LDAP] Added default service name for the Security component's Ldap providers

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

This PR adds a default service name (`ldap`) for the Security component's Ldap factories (`LdapFactory`, `FormLoginLdapFactory` and `HttpBasicLdapFactory`.

Commits
-------

29e3d38 Added default service name for the Security component's Ldap providers
Resources
---------

* [Documentation](https://symfony.com/doc/current/components/filesystem/index.html)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't look right.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woops. I'll submit a patch asap.

fabpot added a commit that referenced this pull request Apr 3, 2016
This PR was merged into the 3.1-dev branch.

Discussion
----------

[Ldap] [Doc] Update README.md

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | yes (doc fix)
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #18387
| License       | MIT
| Doc PR        |

Fixes a typo from #18387

Commits
-------

579e8d4 Update README.md
@csarrazi csarrazi deleted the feature/dx-ldap-add-default-service-name branch May 3, 2016 16:31
@fabpot fabpot mentioned this pull request May 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants