[FrameworkBundle] Calls support for debug:container #18416
Conversation
|
What does it look like with multiple calls? |
|
It will look like this.
|
|
I think this would be a nice addition 👍 Thanks @JhonnyL |
|
Would it be possible to show arguments of the setters as well? I think that On Sun, 3 Apr 2016 13:30 Javier Eguiluz, [email protected] wrote:
|
|
It is possible. Still the command doesn't even show arguments for the debugged service itself. I would hope we can have this merged first and then save arguments support for service and calls etc. to another PR. We would also need to consider if it's worth it e.g. private services as arguments will make output look really ugly and bloated. |
| $calls = $definition->getMethodCalls(); | ||
| if (count($calls) > 0) { | ||
| foreach ($calls as $callData) { | ||
| $output .= "\n".'- Call: `'.$callData[0].'`'; |
There was a problem hiding this comment.
In markdown, should be instead use a sublist ?
- Calls:
- `setParameter`
- `getParameter`There was a problem hiding this comment.
OK, the current proposal is consistent with the display of tags, so this is fine
f609224 to
b2d1038
Compare
|
Updated PR. Removed useless count check. |
|
👍 |
|
👍 |
| @@ -214,6 +214,11 @@ protected function describeContainerDefinition(Definition $definition, array $op | |||
| } | |||
| } | |||
|
|
|||
| $calls = $definition->getMethodCalls(); | |||
| foreach ($calls as $callData) { | |||
| $output .= "\n".'- Call: `'.$callData[0].'`'; | |||
There was a problem hiding this comment.
Imo this should be "Calls" do be consistent with the other descriptors.
There was a problem hiding this comment.
I'm not sure we already using the same thing for Tag and Autowiring Type and if we use Calls we should list them in the same row, did you see how it looks ?
There was a problem hiding this comment.
Oh you are right. This indeed looks right the way it is.
|
👍 |
|
Thank you @JhonnyL. |
…honnyL) This PR was merged into the 3.1-dev branch. Discussion ---------- [FrameworkBundle] Calls support for debug:container | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | no | Fixed tickets | | License | MIT | Doc PR | * Show methods to be called after service initialization in `debug:container` command Commits ------- b2d1038 [FrameworkBundle] Calls support for debug:container
debug:containercommand