[Console] Correct time formatting. #18429
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous behavior caused dramatic jumps in the reported time instead of smoothly transitioning between time ranges. Added tests around the new behavior and the transitions between seconds, minutes, and days.
Fix test that set < 1 sec to 1 sec due to time formatting.
718cefa to
510789c
Compare
|
👍 |
|
Thank you @camporter. |
fabpot
added a commit
that referenced
this pull request
Apr 7, 2016
This PR was squashed before being merged into the 2.7 branch (closes #18429). Discussion ---------- [Console] Correct time formatting. | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #18420 | License | MIT | Doc PR | The previous behavior caused dramatic jumps in the reported time instead of smoothly transitioning between time ranges. Added tests around the new behavior and the transitions between seconds, minutes, and days. Commits ------- b264b66 [Console] Correct time formatting.
This was referenced Apr 29, 2016
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous behavior caused dramatic jumps in the reported time instead of smoothly transitioning between time ranges.
Added tests around the new behavior and the transitions between seconds, minutes, and days.