[Console] use ANSI escape sequences in ProgressBar overwrite method #18496
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ly printed output
|
👍 |
1 similar comment
|
👍 |
|
ANSI codes are very "unreadable". So, what do you think changing code like this: // Erase the line
$this->output->write("\x1B[2K");By something like this? $eraseLineCode = "\x1B[2K";
// ...
$this->output->write($eraseLineCode);Or: $ansiCodes = array(
'eraseLine' => "\x1B[2K"
);
// ...
$this->output->write($ansiCodes['eraseLine']);Maybe in a separate PR? |
|
We can write them as class constants, but what do you think about implementing a class to build escape sequences? |
|
@alekitto Probably a very good idea but out of the scope of this PR. |
|
Thank you @alekitto. |
fabpot
added a commit
that referenced
this pull request
Apr 14, 2016
…te method (alekitto) This PR was squashed before being merged into the 2.7 branch (closes #18496). Discussion ---------- [Console] use ANSI escape sequences in ProgressBar overwrite method | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | maybe | Deprecations? | no | Tests pass? | yes | Fixed tickets | #16957 | License | MIT | Doc PR | Rewritten `overwrite` method in ProgressBar class to use ANSI escape sequences to erase lines. This removes the need to store the last message length as it is not needed to fill the buffer with spaces anymore. As a plus it correctly resets the cursor position while clearing the output If the output is not decorated the behavior has not been changed. Could possibly cause a BC break if testing against the decorated emitted output as binary string Commits ------- b6cca4c [Console] use ANSI escape sequences in ProgressBar overwrite method
|
@fabpot Great! I'll open a new PR against the master branch for the escape sequences builder |
|
@alekitto please before sending a PR, open an issue to discuss about it. A "escape sequence builder" sounds too complex for this simple problem. Thanks! |
This was referenced Apr 29, 2016
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewritten
overwritemethod in ProgressBar class to use ANSI escape sequences to erase lines.This removes the need to store the last message length as it is not needed to fill the buffer with spaces anymore. As a plus it correctly resets the cursor position while clearing the output
If the output is not decorated the behavior has not been changed.
Could possibly cause a BC break if testing against the decorated emitted output as binary string