Fixed a redundant check in DefaultValueResolver #18575
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Heh, you answered on my question here #18308 (comment) |
|
@Koc correct, back when I answered it, the sequences weren't that robust. Now that the So your comment was indeed correct, but ahead of time 👍 |
|
Thank you @iltar. |
fabpot
added a commit
that referenced
this pull request
Apr 28, 2016
This PR was merged into the 3.1-dev branch. Discussion ---------- Fixed a redundant check in DefaultValueResolver | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | ~ | License | MIT | Doc PR | ~ In #18308 I have introduced a `DefaultValueResolver`. When writing documentation, I was planning on adding the code as an example and I noticed it did a check in the request attributes. A default value value should always be injected, whether the request has it or not. In case the request _does_ have the value, it would've already been added and thus never reach the default resolver. Thus as this is never called in the default and configured flows and should not change the default value behavior, I'm removing this. Commits ------- e54c1a6 Fixed a redundant check in DefaultValueResolver
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #18308 I have introduced a
DefaultValueResolver. When writing documentation, I was planning on adding the code as an example and I noticed it did a check in the request attributes. A default value value should always be injected, whether the request has it or not. In case the request does have the value, it would've already been added and thus never reach the default resolver.Thus as this is never called in the default and configured flows and should not change the default value behavior, I'm removing this.