[Cache] Add CacheItem::validateKey utility method #18597
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8913019 to
4297933
Compare
|
👍 |
4297933 to
af09cde
Compare
nicolas-grekas
added a commit
that referenced
this pull request
Apr 20, 2016
…olas-grekas) This PR was merged into the 3.1-dev branch. Discussion ---------- [Cache] Add CacheItem::validateKey utility method | Q | A | ------------- | --- | Branch? | 3.1 | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Ping @dunglas Commits ------- af09cde [Cache] Add CacheItem::validateKey utility method
| @@ -336,19 +335,9 @@ public function __destruct() | |||
| } | |||
| } | |||
|
|
|||
| private function getId($key, $ns = false) | |||
| private function getId($key) | |||
There was a problem hiding this comment.
Sorry for adding comments in a merged PR, but this was merged a bit quickly. I have some concerns about how validateKey() is used. It's a validator, but it's used like a getter or a normalizer.
Instead of this:
private function getId($key)
{
return $this->namespace.CacheItem::validateKey($key);
}Why not using it like this?
private function getId($key)
{
CacheItem::validateKey($key);
return $this->namespace.$key;
}There was a problem hiding this comment.
This would just raise the boilerplate, whereas the current behavior keep it low IMHO.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ping @dunglas