[DI] Fix AutowirePass fatal error with classes that have non-existing parents #18600
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nicolas-grekas
commented
Apr 20, 2016
•
| Q | A |
|---|---|
| Branch? | 2.8 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #18188 |
| License | MIT |
| Doc PR | - |
|
@nicolas-grekas You are a PHP hacker. Great! |
|
|
||
| try { | ||
| spl_autoload_register($throwingAutoloader); |
There was a problem hiding this comment.
this could even be outside the try/catch
|
|
|
@stof I wondered the same, but someone needs to give me a test case that would trigger the fatal error first :) |
|
@nicolas-grekas register an autowired service for a class which has a constructor argument typehinted with a class which extend a missing class |
f799b6c to
202cc77
Compare
Closed
|
👍 |
1 similar comment
|
👍 |
|
... and one more bug fixed, thank you @nicolas-grekas. |
dunglas
added a commit
that referenced
this pull request
Apr 21, 2016
…on-existing parents (hason, nicolas-grekas) This PR was merged into the 2.8 branch. Discussion ---------- [DI] Fix AutowirePass fatal error with classes that have non-existing parents | Q | A | ------------- | --- | Branch? | 2.8 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #18188 | License | MIT | Doc PR | - Commits ------- 202cc77 [DI] Fix AutowirePass fatal error with classes that have non-existing parents 1735b85 [DependencyInjection] Tests for AutowirePass with missing parent class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.