[FrameworkBundle] Add optional logger to cache pools#18631
Merged
Conversation
Member
nicolas-grekas
commented
Apr 25, 2016
| Q | A |
|---|---|
| Branch? | 3.1 |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | - |
| License | MIT |
| Doc PR | - |
2 tasks
b070ab2 to
db2c576
Compare
| <argument /> <!-- namespace --> | ||
| <argument /> <!-- default lifetime --> | ||
| <call method="setLogger"> | ||
| <argument type="service" id="logger" on-invalid="ignore" /> |
Member
There was a problem hiding this comment.
Does on-invalid="ignore" make sense?
Contributor
There was a problem hiding this comment.
Isn't that the way to say "this service does not need to exist", i.e. it is optional?
Member
Author
There was a problem hiding this comment.
on-invalid="ignore" is mandatory because the tag is not handled by the FrameworkBundle but by the MonologBundle, which is not a hard dep of it. This attribute (or its "null" variant) is used everywhere monlog.logger already is.
Member
|
👍 |
nicolas-grekas
added a commit
that referenced
this pull request
Apr 27, 2016
…nicolas-grekas) This PR was merged into the 3.1-dev branch. Discussion ---------- [FrameworkBundle] Add optional logger to cache pools | Q | A | ------------- | --- | Branch? | 3.1 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Commits ------- db2c576 [FrameworkBundle] Add optional logger to cache pools
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.