Updating the error message of an AuthenticationEntryPointInterface #18656
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…turns a non-Response object
|
Looks a lot better than before! Just a question though, why is the "r" in "return" being put on the first line and the "eturn" on the next? |
|
Are we sure we want to merge this in master? Shouldn't it be merged in oldest branches? |
|
Thank you @weaverryan. |
fabpot
added a commit
that referenced
this pull request
Apr 28, 2016
…intInterface (weaverryan) This PR was merged into the 3.1-dev branch. Discussion ---------- Updating the error message of an AuthenticationEntryPointInterface | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | not necessary During a training, we forgot to fill in the `start()` method for an entry point and got a *horrible* error message. Now, if you mess up `start()`, you get:  Thanks! Commits ------- 7b6c56c Updating the error message of an AuthenticationEntryPointInterface returns a non-Response object
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During a training, we forgot to fill in the
start()method for an entry point and got a horrible error message. Now, if you mess upstart(), you get:Thanks!