[Cache] Dont use Redis connection when not required #18659
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nicolas-grekas
commented
Apr 28, 2016
•
| Q | A |
|---|---|
| Branch? | 3.1 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | - |
| License | MIT |
| Doc PR | - |
| if (preg_match('#[^-+_.A-Za-z0-9]#', $namespace, $match)) { | ||
| throw new InvalidArgumentException(sprintf('RedisAdapter namespace contains "%s" but only characters in [-+_.A-Za-z0-9] are allowed.', $match[0])); | ||
| } | ||
| $this->redis = $redisConnection; | ||
| $this->redis->setOption(\Redis::OPT_PREFIX, $namespace); |
There was a problem hiding this comment.
this breaks things if the same Redis connection is reused for several things, as you change its state
05b5893 to
1165459
Compare
| foreach ($ids as $id) { | ||
| if (false !== $value = $values[$index++]) { | ||
| $result[$id] = unserialize($value); | ||
| $result = array(); |
There was a problem hiding this comment.
As it is for Sf 3.1 brackets were great, isn't it ?
There was a problem hiding this comment.
@Nek- our policy is to not use them, to keep consistency in the codebase (and we cannot convert the whole codebase to the short array syntax, as we will need to merge 2.8 into 3.x during 3 years, and we don't want git conflicts each time we change a line dealing with an array)
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Apr 28, 2016
…as-grekas) This PR was merged into the 3.1-dev branch. Discussion ---------- [Cache] Dont use Redis connection when not required | Q | A | ------------- | --- | Branch? | 3.1 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Commits ------- 1165459 [Cache] Dont use Redis connection when not required
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.