[Form] [DoctrineBridge] updated changelogs after #18359 #18664
Conversation
0618b69 to
7fad426
Compare
| @@ -26,6 +26,8 @@ class DoctrineChoiceLoader implements ChoiceLoaderInterface | |||
| { | |||
| /** | |||
| * @var ChoiceListFactoryInterface | |||
| * | |||
| * @deprecated since 3.1 to be removed in 4.0. | |||
There was a problem hiding this comment.
No need to tag private vars as deprecated.
There was a problem hiding this comment.
Alright! I thought as it is just deprecated to pass it in the constructor, it may be forgotten to be removed in 4.0.
Should we keep a simple comment like BC, to be removed in 4.0. or there's no need too?
There was a problem hiding this comment.
In fact, this property, it's assignment and the constructor parameter can simply be removed (and then ignore any factory passed as first argument to the constructor).
It's a private property, so it couldn't be used by the outside world so there is no need for backwards compatibility.
There was a problem hiding this comment.
You're right, I thought about that but didn't dare. I guess I should, thanks!
7fad426 to
1c8dc9d
Compare
|
Fixed, thanks! I also added a note in the upgrade files, is that correct? |
|
Thank you @HeahDude. |
…(HeahDude) This PR was merged into the 3.1-dev branch. Discussion ---------- [Form] [DoctrineBridge] updated changelogs after #18359 | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | ~ | License | MIT | Doc PR | ~ follows #18359. Commits ------- 1c8dc9d [Form] [DoctrineBridge] updated changelogs after #18359
follows #18359.