[HttpKernel] Add request method to logger messages#18676
Merged
Conversation
Member
|
You need to update some tests too. Status: Needs work |
While debugging some functional tests I was looking at the test.log. It would have been quite useful to know if the request was a POST or GET. This adds to the log details.
Contributor
Author
|
Thanks, I wasn't sure if it would be accepted. Tests have been updated. |
Member
|
Thank you @gnat42. |
fabpot
added a commit
that referenced
this pull request
May 13, 2016
…at42) This PR was merged into the 3.1-dev branch. Discussion ---------- [HttpKernel] Add request method to logger messages | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | While debugging some functional tests I was looking at the test.log. It would have been quite useful to know if the request was a POST or GET. This adds the request method to the log details. Commits ------- d751d59 Add request method to logger messages
Contributor
Author
|
No problem. Any chance this would be applied to older branches like 2.7/2.8 or 2.3? or is it considered a BC? |
Member
|
this is not a bug fix, so it won't go into maintenance branches (it is not a BC break, which is why it can go into 3.1 rather than waiting for 4.0) |
Contributor
Author
|
Ah I see. Thanks for the clarification. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While debugging some functional tests I was looking at the test.log. It would have been quite useful to know if the request was a POST or GET. This adds the request method to the log details.