[Cache] Add DSN based Redis connection factory #18681
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
76734c4 to
0952057
Compare
| * | ||
| * @return \Redis | ||
| */ | ||
| public static function createConnection($dsn, array $options = array()) |
There was a problem hiding this comment.
Missing docblock for argument 2.
0952057 to
9a1131a
Compare
9a1131a to
3073efb
Compare
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
May 1, 2016
…s-grekas) This PR was merged into the 3.1-dev branch. Discussion ---------- [Cache] Add DSN based Redis connection factory | Q | A | ------------- | --- | Branch? | 3.1 | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Required by #18667 Commits ------- 3073efb [Cache] Add DSN based Redis connection factory
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required by #18667