[FrameworkBundle] Default to Apcu+Filesystem cache chain #18715
Conversation
8622940 to
575b359
Compare
575b359 to
f55041e
Compare
|
👍 |
f55041e to
1a42cdd
Compare
|
Includes #18716 until it's merged |
005e8d4 to
e300496
Compare
| $apcu->setLogger($logger); | ||
| } | ||
|
|
||
| return new ChainAdapter(array($apcu, $fs)); |
There was a problem hiding this comment.
Not sure if creation of the default adapter belongs here. Imo we should deal with this in the FrameworkBundle extension.
There was a problem hiding this comment.
factory moved to FrameworkBundle (I don't like creating/loading yet another utility class just for the factory)
There was a problem hiding this comment.
factory back on the component following comment from @fabpot
e300496 to
0a39f29
Compare
| @@ -1037,6 +1037,7 @@ private function registerPropertyInfoConfiguration(array $config, ContainerBuild | |||
|
|
|||
| private function registerCacheConfiguration(array $config, ContainerBuilder $container, XmlFileLoader $loader) | |||
| { | |||
| $container->setParameter('kernel.cache_nonce', substr(base64_encode(md5(uniqid(mt_rand(), true), true)), 0, 4)); | |||
There was a problem hiding this comment.
Using mt_rand means that each rebuilding of the container will change this value. And each server behind the load balancer may have a different value if they build their container themselves (rather than building it once before deploying), making it unusable for configuring a shared cache. Is it the intended behavior ?
There was a problem hiding this comment.
Yes, this is the indented behavior: this nonce is only for local caches (apcu is the only use case in fact today).
7ea44b2 to
3a3e789
Compare
|
ping @symfony/deciders votes pending for 3.1-beta which should/may be released tomorrow |
3a3e789 to
40e0571
Compare
| @@ -22,6 +22,17 @@ | |||
| <tag name="cache.pool" /> | |||
| </service> | |||
|
|
|||
| <service id="cache.adapter.system" class="Symfony\Component\Cache\Adapter\ChainAdapter" abstract="true"> | |||
| <factory class="Symfony\Bundle\FrameworkBundle\FrameworkBundle" method="createSystemCache" /> | |||
There was a problem hiding this comment.
I would move this factory to the component instead as the code in the method is not tied to the full-stack framework. I'd like to be able to reuse this strategy into Silex for instance.
40e0571 to
9f71fb9
Compare
| @@ -22,6 +22,17 @@ | |||
| <tag name="cache.pool" /> | |||
| </service> | |||
|
|
|||
| <service id="cache.adapter.system" class="Symfony\Component\Cache\Adapter\ChainAdapter" abstract="true"> | |||
There was a problem hiding this comment.
What about using the interface as the class here as the service can also just be a FilesystemAdapter?
|
👍 |
5e3dc85 to
ae1d7dc
Compare
ae1d7dc to
b9b57f9
Compare
|
Thank you @nicolas-grekas. |
…in (nicolas-grekas) This PR was merged into the 3.1-dev branch. Discussion ---------- [FrameworkBundle] Default to Apcu+Filesystem cache chain | Q | A | ------------- | --- | Branch? | 3.1 | Bug fix? | yes (perf) | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - In #16838, @dunglas benched that the filesystem cache is not the fastest one (not a surprise). Yet, it is the default for now. I propose to replace this default by a dynamically created one that uses APCu when available (of course, we cannot do the check at container-build time), chained with the filesystem. The benefit is double: APCu is automatically used when available without any configuration, and cache warming up is seeded by the filesystem cache so that the apcu cache can benefit from it. Commits ------- b9b57f9 [FrameworkBundle] Default to Apcu+Filesystem cache chain
In #16838, @dunglas benched that the filesystem cache is not the fastest one (not a surprise).
Yet, it is the default for now. I propose to replace this default by a dynamically created one that uses APCu when available (of course, we cannot do the check at container-build time), chained with the filesystem.
The benefit is double: APCu is automatically used when available without any configuration, and cache warming up is seeded by the filesystem cache so that the apcu cache can benefit from it.