[Validator] Support for DateTimeImmutable #18759
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -43,6 +43,16 @@ public function testDateTimeClassIsValid() | |||
| } | |||
|
|
|||
| /** | |||
| * @requires PHP 5.5.0 | |||
There was a problem hiding this comment.
not needed as Symfony 3.0 already requires PHP 5.5.9
|
👍 Status: reviewed Travis error looks unrelated |
|
👍 |
|
Thank you @krzysiekpiasecki. |
nicolas-grekas
added a commit
that referenced
this pull request
May 19, 2016
This PR was squashed before being merged into the 3.0 branch (closes #18759). Discussion ---------- [Validator] Support for DateTimeImmutable | Q | A | ------------- | --- | Branch? | 3.0 | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #18752 | License | MIT | Doc PR | When validating with DateTime constraint UnexpectedTypeException is thrown for DateTimeImmutable instances. Why PR? - DateTimeImmutable behaves like a DateTime. Both implements the same interface DateTimeInterface. - DateTimeInterface cannot be implemented by the client. Commits ------- f49659f [Validator] Support for DateTimeImmutable
Merged
Merged
fabpot
added a commit
that referenced
this pull request
Jan 2, 2017
…mes (xabbuh) This PR was merged into the 3.3-dev branch. Discussion ---------- [Validator] support DateTimeInterface instances for times | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | The same has already been done for the `Date` and `DateTime` constraints in #18759. Commits ------- 1fa9276 support DateTimeInterface instances for times
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When validating with DateTime constraint UnexpectedTypeException is thrown for DateTimeImmutable instances.
Why PR?