Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Added people - person singularization #18824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 23, 2016
Merged

Conversation

Keeo
Copy link
Contributor

@Keeo Keeo commented May 20, 2016

Q A
Branch? 3.0, this 'bug' is present even in older versions
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR

Proper singularization for people into person. This change does not affect singularization of persons.

@Keeo Keeo changed the title Added people - person inflection Added people - person singularization May 20, 2016
@dunglas
Copy link
Member

dunglas commented May 22, 2016

Status: reviewed

👍

Fabbot error is a false positive.
A PR should also be opened on older version of this class (in the PropertyInfo component).

@Keeo
Copy link
Contributor Author

Keeo commented May 22, 2016

Will do in few hours

@Keeo
Copy link
Contributor Author

Keeo commented May 22, 2016

Here it is for v2.8 - [#18839]

fabpot added a commit that referenced this pull request May 23, 2016
This PR was submitted for the 2.8 branch but it was merged into the 2.3 branch instead (closes #18839).

Discussion
----------

People - person singularization

| Q             | A
| ------------- | ---
| Branch?       | 2.8
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

Bugfix for version 2.8 - more information [#18824]

Commits
-------

02070f9 People - person singularization
@fabpot
Copy link
Member

fabpot commented May 23, 2016

Thank you @Keeo.

@fabpot fabpot merged commit 5bc4b36 into symfony:master May 23, 2016
fabpot added a commit that referenced this pull request May 23, 2016
This PR was merged into the 3.2-dev branch.

Discussion
----------

Added people - person singularization

| Q             | A
| ------------- | ---
| Branch?       | 3.0, this 'bug' is present even in older versions
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

Proper singularization for people into person. This change does not affect singularization of persons.

Commits
-------

5bc4b36 Added people - person inflection
@Keeo Keeo deleted the people-person branch May 23, 2016 09:06
@fabpot fabpot mentioned this pull request Oct 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants