[Ldap] Fixed issue with legacy client initialisation #18944
Conversation
|
Any way to add some tests? |
|
Sure! I'll try to find some time for this tomorrow |
|
@csarrazi This fix worked for me. Thanks |
| @@ -24,13 +24,22 @@ | |||
|
|
|||
| public function __construct($host = null, $port = 389, $version = 3, $useSsl = false, $useStartTls = false, $optReferrals = false, LdapInterface $ldap = null) | |||
| { | |||
| if ((bool) $useSsl) { | |||
There was a problem hiding this comment.
True. However this was kept to ensure the previous behaviour.
I can remove the cast, if needed.
|
btw, this class is missing its deprecation warning |
|
You mean in the constructor, right? |
|
@csarrazi stof means after the namespace declaration. See |
|
Ok. I'll check this tonight! Thanks for the info @nicolas-grekas! |
|
@nicolas-grekas @stof Done. |
| @@ -11,6 +11,8 @@ | |||
|
|
|||
| namespace Symfony\Component\Ldap; | |||
|
|
|||
| @trigger_error('The '.__NAMESPACE__.'\LdapClient class is deprecated since version 3.1 and will be removed in 4.0. Use directly the Ldap class instead.', E_USER_DEPRECATED); | |||
There was a problem hiding this comment.
Use the Ldap class directly instead.
|
👍 |
|
It will be okay to remove them for 4.0. The
|
|
Thank you @csarrazi. |
…razi) This PR was merged into the 3.1 branch. Discussion ---------- [Ldap] Fixed issue with legacy client initialisation | Q | A | ------------- | --- | Branch? | 3.1 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #18725 (comment) | License | MIT | Doc PR | Thanks @uvups for noticing this. Commits ------- 6804efe Fixed issue with legacy client initialization
Thanks @uvups for noticing this.