[3.1][Security] Fix DebugAccessDecisionManager when object is not a scalar #18949
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
romainneutron
commented
Jun 2, 2016
| Q | A |
|---|---|
| Branch? | 3.1 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | N/A |
| License | MIT |
|
👍 |
|
I've not added test because this class is not tested at all. If you want, I can add some |
|
would be great to add some tests, yeah |
| return sprintf('%s (%s)', gettype($object), $object); | ||
| if (is_scalar($object)) { | ||
| return sprintf('%s (%s)', gettype($object), $object); | ||
| } else { |
f85b568 to
ce015c0
Compare
|
PR updated, tests added |
ce015c0 to
c916783
Compare
| { | ||
| $object = new \stdClass(); | ||
|
|
||
| yield [[['attributes' => ['ATTRIBUTE_1'], 'object' => 'NULL', 'result' => false]], null]; |
There was a problem hiding this comment.
we don't use the short array syntax in Symfony
8976fd1 to
af15dfb
Compare
|
PR updated, comments addressed |
af15dfb to
ff2d189
Compare
|
Thank you @romainneutron. |
fabpot
added a commit
that referenced
this pull request
Jun 3, 2016
… is not a scalar (romainneutron) This PR was merged into the 3.1 branch. Discussion ---------- [3.1][Security] Fix DebugAccessDecisionManager when object is not a scalar | Q | A | ------------- | --- | Branch? | 3.1 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | N/A | License | MIT Commits ------- ff2d189 [Security] Fix DebugAccessDecisionManager when object is not a scalar
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.