[3.1][HttpKernel] Fix RequestDataCollector starting the session #18954
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
In the In general, it looks good to me then. It means redirection detection won't work if session are not already used. Related to #6036 |
|
👍 |
0747e6b to
ab62dcf
Compare
|
I've updated the PR according to @Tobion comment, see https://github.com/symfony/symfony/pull/18954/files#diff-e8f5b14fbfbbeac60fc9f3abe310c3b0R133 |
|
Thank you @romainneutron. |
fabpot
added a commit
that referenced
this pull request
Jun 3, 2016
…ssion (romainneutron) This PR was merged into the 3.1 branch. Discussion ---------- [3.1][HttpKernel] Fix RequestDataCollector starting the session | Q | A | ------------- | --- | Branch? | 3.1 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #18951 | License | MIT The RequestDataCollector starts a non-started session on kernel response. This produces bug #18951 I'm not sure if this is the right fix, let's discuss it. Commits ------- ab62dcf [HttpKernel] Fix RequestDataCollector starting the session
|
Thanks for that PR! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The RequestDataCollector starts a non-started session on kernel response. This produces bug #18951
I'm not sure if this is the right fix, let's discuss it.