👍 LGTM

👍

What about replacing getMock() with createMock() and adding compatibility trait for phpunit < 5.4:

trait PhpUnitCompat
{
    /**
     * @param string $originalClassName
     *
     * @return \PHPUnit_Framework_MockObject_MockObject
     */
    public function createMock($originalClassName)
    {
        if (is_callable('parent::createMock')) {
            return parent::createMock($originalClassName);
        }

        return $this->getMockBuilder($originalClassName)
            ->disableOriginalConstructor()
            ->disableOriginalClone()
            ->disableArgumentCloning()
            ->getMock();
    }
}

We would have to include the trait everywhere in our testsuite, because we cannot require PHPUnit 5 in our testsuite (as we support PHP 5.5). So it is not worth it IMO.

Thank you @iltar.

Great. Which version will this appear in?

@codeinabox Symfony 3.2

In the interim is there an easy way to downgrade my version of PHPUnit? I tried setting the version constraint to 5.3.* but composer didn't seem to like that

Not sure I understand. In which context do you run into issues?

I have a lot of unit tests for my forms that extend Symfony\Component\Form\Test\TypeTestCase, which results in getMock() deprecation warnings.

That class was updated in #19128 which will be part of 2.7.15.