Undefined variable $name #19166
Merged
Undefined variable $name #19166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
janczer
commented
Jun 24, 2016
| Q | A |
|---|---|
| Branch? | "master" for new features / 2.7, 2.8, 3.0 or 3.1 for fixes |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| License | MIT |
| @@ -65,7 +65,7 @@ public function setInitialPlace($place) | |||
| public function addPlace($place) | |||
| { | |||
| if (!preg_match('{^[\w\d_-]+$}', $place)) { | |||
| throw new InvalidArgumentException(sprintf('The place "%s" contains invalid characters.', $name)); | |||
| throw new InvalidArgumentException(sprintf('The place "%s" contains invalid characters.', $place)); | |||
There was a problem hiding this comment.
This highlights missing tests on error cases.
|
Thank you @IvanMenshykov. |
fabpot
added a commit
that referenced
this pull request
Jun 24, 2016
This PR was merged into the 3.2-dev branch. Discussion ---------- Undefined variable $name | Q | A | ------------- | --- | Branch? | "master" for new features / 2.7, 2.8, 3.0 or 3.1 for fixes | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | License | MIT Commits ------- 8304bcc Undefined variable $name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.