[Console] Decouple SymfonyStyle from TableCell #19173
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| $table = new Table($this); | ||
| $table->setHeaders($headers); | ||
| $table->setRows($rows); | ||
| $table->setStyle('symfony-style-guide'); | ||
| $table->setStyle((clone Table::getStyleDefinition('symfony-style-guide'))->setCellHeaderFormat('<info>%s</info>')); |
There was a problem hiding this comment.
this syntax cannot be used in Symfony 2.7, because it works only for PHP 5.4+, and Symfony 2.3 still supports PHP 5.3
|
👍 |
|
Thank you @ro0NL. |
fabpot
added a commit
that referenced
this pull request
Jun 29, 2016
This PR was squashed before being merged into the 2.7 branch (closes #19173). Discussion ---------- [Console] Decouple SymfonyStyle from TableCell | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | ~ | License | MIT | Doc PR | ~ Alternative approach, ie BC, for #19136 (i prefer that one though, as it also _fixes_ #19123 ) Commits ------- 51f59d6 [Console] Decouple SymfonyStyle from TableCell
nicolas-grekas
added a commit
that referenced
this pull request
Jun 29, 2016
This PR was merged into the 2.8 branch. Discussion ---------- [FrameworkBundle] Fix fixtures | Q | A | ------------- | --- | Branch? | 2.8 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #19173 #19223 | License | MIT | Doc PR | - Commits ------- d175477 [FrameworkBundle] Fix fixtures
This was referenced Jun 30, 2016
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative approach, ie BC, for #19136 (i prefer that one though, as it also fixes #19123 )