Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Validator][Choice] Make strict the default option for choice validation #19257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

[Validator][Choice] Make strict the default option for choice validation #19257

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
76e3ef1
Make strict the default option for choice validation
peterrehm Jul 1, 2016
fdb7972
Deprecated setting the strict option to false in the choice constraint
peterrehm Jul 10, 2016
3c7486e
Marked non strict tests as legacy
peterrehm Jul 13, 2016
5c3b69a
Updated upgrade information
peterrehm Jul 13, 2016
f4f62b9
Added upgrade information for 4.0
peterrehm Aug 8, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Marked non strict tests as legacy
  • Loading branch information
@peterrehm
peterrehm committed Jul 13, 2016
commit 3c7486ebe211f76e6fa7bed22bd88b969cd8642c
6 changes: 6 additions & 0 deletions src/Symfony/Component/Validator/Tests/Constraints/ChoiceValidatorTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,6 +245,9 @@ public function testTooManyChoices()
->assertRaised();
}

/**
* @group legacy
*/
public function testNonStrict()
{
$constraint = new Choice(array(
Expand Down Expand Up @@ -286,6 +289,9 @@ public function testStrictDisallowsDifferentType()
->assertRaised();
}

/**
* @group legacy
*/
public function testNonStrictWithMultipleChoices()
{
$constraint = new Choice(array(
Expand Down