[HttpKernel] Clarify deprecation of non-scalar values in surrogate fragment renderer #19281
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
chalasr
commented
Jul 4, 2016
| Q | A |
|---|---|
| Branch? | 3.1 |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #19262 |
| License | MIT |
| Doc PR | ~ |
| @@ -65,7 +65,7 @@ public function render($uri, Request $request, array $options = array()) | |||
| { | |||
| if (!$this->surrogate || !$this->surrogate->hasSurrogateCapability($request)) { | |||
| if ($uri instanceof ControllerReference && $this->containsNonScalars($uri->attributes)) { | |||
| @trigger_error('Passing objects as part of URI attributes to the ESI and SSI rendering strategies is deprecated since version 3.1, and will be removed in 4.0. Use a different rendering strategy or pass scalar values.', E_USER_DEPRECATED); | |||
| @trigger_error('Passing objects or arrays as part of URI attributes to the ESI and SSI rendering strategies is deprecated since version 3.1, and will be removed in 4.0. Use a different rendering strategy or pass scalar values.', E_USER_DEPRECATED); | |||
There was a problem hiding this comment.
What about "Passing non scalar values [...]" instead?
There was a problem hiding this comment.
I hesitated because it is already written "pass scalar values" at the end, but if you think it is clearer, let's use it.
|
We should update the upgrade files too. |
729701b to
e8ea461
Compare
|
I did the change. |
|
👍 |
|
@chalasr The |
…nderer Update UPGRADE-3.1 too Use non-scalar values as deperecated type Update UPGRADE-4.0 too
e8ea461 to
b088978
Compare
|
I missed it, it's ok now @xabbuh. |
|
👍 |
|
Thank you @chalasr. |
fabpot
added a commit
that referenced
this pull request
Jul 4, 2016
… surrogate fragment renderer (chalasr) This PR was merged into the 3.1 branch. Discussion ---------- [HttpKernel] Clarify deprecation of non-scalar values in surrogate fragment renderer | Q | A | ------------- | --- | Branch? | 3.1 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #19262 | License | MIT | Doc PR | ~ Commits ------- b088978 [HttpKernel] Clarify deprecation of non-scalar values in surrogate renderer
fabpot
added a commit
that referenced
this pull request
Aug 27, 2016
…ragment renderer (chalasr) This PR was merged into the 3.1 branch. Discussion ---------- [HttpKernel] Fix assertion of deprecation in surrogate fragment renderer | Q | A | ------------- | --- | Branch? | 3.1 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a The message has been changed in #19281 but not the corresponding assertion Commits ------- 4245bac [HttpKernel] Fix assertion of deprecation in fragment renderer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.