[WebProfilerBundle][Form][DX] To expand the form nodes that contains children with errors #19339

yceruto · 2016-07-11T15:33:34Z

Q	A
Branch?	master
Bug fix?	no
New feature?	yes
BC breaks?	no
Deprecations?	no
Tests pass?	yes
Fixed tickets	-
License	MIT
Doc PR	-

Currently when we use nested forms and an error occurs into one of them, it's not displayed "easily" in the form panel profiler:

This happen because only the root form is expanded and the children are shown collapsed "by default".

The main problem is to search where is the form with error.

The purpose of this PR is to show expanded all forms that contains children with error, reducing a little bit the developer's time when debugging.

PR result when we access to the form panel profiler:

In red the full path to the error.

yceruto · 2016-07-11T15:55:44Z

Tests fails (no related)
OK Form Tests

javiereguiluz · 2016-07-11T15:58:12Z

This is a fantastic DX improvement! Thanks @yceruto.

👍

HeahDude · 2016-07-11T16:23:48Z

Thanks for that feature!

eXtreme · 2016-07-12T07:57:58Z

The other idea for solving this would be to somehow show the number of children errors in parents (maybe with different color than red).

…rors

yceruto · 2016-07-12T17:54:45Z

I just rebased! All tests in green again 😃

yceruto · 2016-07-12T19:00:02Z

@eXtreme would be another solution but in that case we would have to open each node until the form with error. In this way the form error is in sight 👀 ;)

apfelbox · 2016-07-13T07:52:58Z

@eXtreme @yceruto why not both?

yceruto · 2016-07-14T13:36:40Z

I've found a pain point to make this #19339 (comment) proposal:

Suppose you have a form with two children, where one of them has the error_bubbling property to true and both children have an error, right now, the result will be:

- form [1]
    - child1 <--- error_bubbling = true, so the error is passed to parent form
    - child2 [1]

If we implement this proposal, the result will be:

- form [1][1] 
    - child1
    - child2 [1]

Which would be confused IMO, even if we put different colors.

WDYT ?

ogizanagi · 2016-07-15T14:37:56Z

@yceruto : I was for both proposals, but I came to the same point you did. So IMHO, your solution is enough. But if we wanted to improve this a little bit, I'd say that's not the number of errors in children forms which is important, but rather showing the path to the error. This is what you do by expanding all nodes with errors, but why not simply highlighting in red the full path ?

- form // some children contain errors, red
    - child1 // No error, grey
-   - child2 [1] // Has error, red

yceruto · 2016-07-15T17:16:24Z

I like your proposal @ogizanagi I say let's do it.

yceruto · 2016-07-21T13:12:28Z

Status: Needs work

yceruto · 2016-07-26T03:45:56Z

Updated!

Status: Needs Review

yceruto · 2016-07-29T12:23:51Z

I've updated the result screenshot with highlighting error path feature, thanks to @eXtreme, @apfelbox and @ogizanagi by the idea 👍

fabpot · 2016-07-29T12:27:22Z

👍

nicolas-grekas · 2016-08-11T12:01:39Z

👍
Status: reviewed

yceruto · 2016-08-22T17:05:54Z

Ready for @symfony/mergers?

fabpot · 2016-08-22T17:27:24Z

Thank you @yceruto.

… that contains children with errors (yceruto) This PR was squashed before being merged into the 3.2-dev branch (closes #19339). Discussion ---------- [WebProfilerBundle][Form][DX] To expand the form nodes that contains children with errors | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Currently when we use nested forms and an error occurs into one of them, it's not displayed "easily" in the form panel profiler: ![first](https://cloud.githubusercontent.com/assets/2028198/17125622/1fd15142-52c3-11e6-830e-17b3e341ba60.png) This happen because only the root form is expanded and the children are shown collapsed "by default". **The main problem is to search where is the form with error**. The purpose of this PR is to show expanded all forms that contains children with error, reducing a little bit the developer's time when debugging. PR result when we access to the form panel profiler: ![form-error-result](https://cloud.githubusercontent.com/assets/2028198/17125447/83eb9c0c-52c1-11e6-94bc-a2a7492eea43.png) In red the full path to the error. ![form-error-result2](https://cloud.githubusercontent.com/assets/2028198/17125459/a04de95e-52c1-11e6-8980-84a5dcd0914a.png) Commits ------- d626b28 [WebProfilerBundle][Form][DX] To expand the form nodes that contains children with errors

…m nodes that contains children with errors (yceruto) This PR was squashed before being merged into the 3.2-dev branch (closes symfony#19339). Discussion ---------- [WebProfilerBundle][Form][DX] To expand the form nodes that contains children with errors | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Currently when we use nested forms and an error occurs into one of them, it's not displayed "easily" in the form panel profiler: ![first](https://cloud.githubusercontent.com/assets/2028198/17125622/1fd15142-52c3-11e6-830e-17b3e341ba60.png) This happen because only the root form is expanded and the children are shown collapsed "by default". **The main problem is to search where is the form with error**. The purpose of this PR is to show expanded all forms that contains children with error, reducing a little bit the developer's time when debugging. PR result when we access to the form panel profiler: ![form-error-result](https://cloud.githubusercontent.com/assets/2028198/17125447/83eb9c0c-52c1-11e6-94bc-a2a7492eea43.png) In red the full path to the error. ![form-error-result2](https://cloud.githubusercontent.com/assets/2028198/17125459/a04de95e-52c1-11e6-8980-84a5dcd0914a.png) Commits ------- d626b28 [WebProfilerBundle][Form][DX] To expand the form nodes that contains children with errors

carsonbot added Status: Needs Review WebProfilerBundle Form DX DX = Developer eXperience (anything that improves the experience of using Symfony) Feature labels Jul 11, 2016

yceruto force-pushed the web-profiler-form-errors branch from 587fa43 to 095d15a Compare July 12, 2016 17:26

[WebProfilerBundle][Form] expand forms that contains children with er…

00b8785

…rors

yceruto force-pushed the web-profiler-form-errors branch from 095d15a to 00b8785 Compare July 12, 2016 17:33

yceruto changed the title ~~[WebProfilerBundle][Form][DX] Expand forms that contains children with errors~~ [WIP][WebProfilerBundle][Form][DX] Expand forms that contains children with errors Jul 15, 2016

carsonbot added Status: Needs Work and removed Status: Needs Review labels Jul 21, 2016

highlighting full error path

a85adae

carsonbot added Status: Needs Review and removed Status: Needs Work labels Jul 26, 2016

yceruto changed the title ~~[WIP][WebProfilerBundle][Form][DX] Expand forms that contains children with errors~~ [WebProfilerBundle][Form][DX] Expand forms that contains children with errors Jul 26, 2016

yceruto changed the title ~~[WebProfilerBundle][Form][DX] Expand forms that contains children with errors~~ [WebProfilerBundle][Form][DX] To expand the form nodes that contains children with errors Jul 27, 2016

carsonbot added Status: Reviewed and removed Status: Needs Review labels Aug 11, 2016

fabpot closed this Aug 22, 2016

yceruto deleted the web-profiler-form-errors branch August 22, 2016 17:33

fabpot mentioned this pull request Oct 27, 2016

Release v3.2.0-BETA1 #20317

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WebProfilerBundle][Form][DX] To expand the form nodes that contains children with errors #19339

[WebProfilerBundle][Form][DX] To expand the form nodes that contains children with errors #19339

yceruto commented Jul 11, 2016 •

edited

Loading

yceruto commented Jul 11, 2016 •

edited

Loading

javiereguiluz commented Jul 11, 2016

HeahDude commented Jul 11, 2016

eXtreme commented Jul 12, 2016

yceruto commented Jul 12, 2016 •

edited

Loading

yceruto commented Jul 12, 2016 •

edited

Loading

apfelbox commented Jul 13, 2016

yceruto commented Jul 14, 2016 •

edited

Loading

ogizanagi commented Jul 15, 2016

yceruto commented Jul 15, 2016

yceruto commented Jul 21, 2016

yceruto commented Jul 26, 2016

yceruto commented Jul 29, 2016 •

edited

Loading

fabpot commented Jul 29, 2016

nicolas-grekas commented Aug 11, 2016

yceruto commented Aug 22, 2016

fabpot commented Aug 22, 2016

[WebProfilerBundle][Form][DX] To expand the form nodes that contains children with errors #19339

[WebProfilerBundle][Form][DX] To expand the form nodes that contains children with errors #19339

Conversation

yceruto commented Jul 11, 2016 • edited Loading

yceruto commented Jul 11, 2016 • edited Loading

javiereguiluz commented Jul 11, 2016

HeahDude commented Jul 11, 2016

eXtreme commented Jul 12, 2016

yceruto commented Jul 12, 2016 • edited Loading

yceruto commented Jul 12, 2016 • edited Loading

apfelbox commented Jul 13, 2016

yceruto commented Jul 14, 2016 • edited Loading

ogizanagi commented Jul 15, 2016

yceruto commented Jul 15, 2016

yceruto commented Jul 21, 2016

yceruto commented Jul 26, 2016

yceruto commented Jul 29, 2016 • edited Loading

fabpot commented Jul 29, 2016

nicolas-grekas commented Aug 11, 2016

yceruto commented Aug 22, 2016

fabpot commented Aug 22, 2016

yceruto commented Jul 11, 2016 •

edited

Loading

yceruto commented Jul 11, 2016 •

edited

Loading

yceruto commented Jul 12, 2016 •

edited

Loading

yceruto commented Jul 12, 2016 •

edited

Loading

yceruto commented Jul 14, 2016 •

edited

Loading

yceruto commented Jul 29, 2016 •

edited

Loading