[Console] Move AddConsoleCommandPass from FrameworkBundle to Console. #19443

bcremer · 2016-07-27T08:30:39Z

Q	A
Branch?	master
Bug fix?	no
New feature?	yes
BC breaks?	yes
Deprecations?	yes
Tests pass?	yes
Fixed tickets	#19440
License	MIT
Doc PR	-

mcfedr · 2016-07-27T10:19:30Z

Maybe worth merging (or reviewing) #19305 first so that it doesnt conflict.

dunglas · 2016-07-27T14:52:56Z

src/Symfony/Bundle/FrameworkBundle/composer.json

@@ -22,6 +22,7 @@
        "symfony/class-loader": "~3.2",
        "symfony/dependency-injection": "~3.2",
        "symfony/config": "~2.8|~3.0",
+        "symfony/console": "~3.2",


This can be removed. Because of the class_exists call, if the installed component is an older version or isn't installed it will still work. Maybe should you add a another test to not load the deprecated pass if the component is not installed at all (to prevent throwing an illegitimate deprecation warning).

Removed the dependency.

nicolas-grekas · 2016-07-28T06:47:24Z

src/Symfony/Bundle/FrameworkBundle/DependencyInjection/Compiler/AddConsoleCommandPass.php

 */
 class AddConsoleCommandPass implements CompilerPassInterface
 {
+    public function __construct()
+    {
+        @trigger_error(sprintf('%s is deprecated as of 3.2 and will be removed in 4.0. Use Symfony\Component\Console\DependencyInjection\AddConsoleCommandPass instead.', __CLASS__), E_USER_DEPRECATED);


this should be jus below the namespace declaration, see other places in the code base

Good point, changed.

nicolas-grekas · 2016-07-28T07:33:29Z

src/Symfony/Bundle/FrameworkBundle/DependencyInjection/Compiler/AddConsoleCommandPass.php

@@ -11,13 +11,17 @@

 namespace Symfony\Bundle\FrameworkBundle\DependencyInjection\Compiler;

+@trigger_error(sprintf('%s is deprecated as of 3.2 and will be removed in 4.0. Use Symfony\Component\Console\DependencyInjection\AddConsoleCommandPass instead.', __CLASS__), E_USER_DEPRECATED);


AddConsoleCommandPass::class instead of __CLASS__ (which is undefined)

stof · 2016-07-28T11:04:29Z

src/Symfony/Component/Console/composer.json

        "symfony/filesystem": "~2.8|~3.0",
        "symfony/process": "~2.8|~3.0",
        "psr/log": "~1.0"
    },
    "suggest": {
+        "symfony/dependency-injection": "",


I would remove this suggestion. The DI component does not allow to add more features to the Console component.

The compiler pass is useful only for people already using the component. So the suggestion is just useless noise.

Makes sense; changed.

fabpot · 2016-09-14T21:49:44Z

Tests do not pass because of the deprecation.

bcremer · 2016-09-15T06:19:34Z

Tests are now all fixed.

xabbuh · 2016-10-14T12:44:31Z

UPGRADE-3.2.md

@@ -6,6 +6,7 @@ FrameworkBundle

 * The `Controller::getUser()` method has been deprecated and will be removed in
   Symfony 4.0; typehint the security user object in the action instead.
+ * The `Symfony\Bundle\FrameworkBundle\DependencyInjection\Compiler\AddConsoleCommandPass` has been deprecated. Use `Symfony\Component\Console\DependencyInjection\AddConsoleCommandPass` instead.


Please also add this to the UPGRADE-4.0.md (but reword it to "removed" there).

xabbuh · 2016-10-14T12:48:12Z

src/Symfony/Component/Console/Tests/DependencyInjection/AddConsoleCommandPassTest.php

+        $container->compile();
+    }
+
+    public function testHttpKernelRegisterCommandsIngoreCommandAsAService()


This whole test case looks a bit suspicious to me. We don't have anything HttpKernel specific here, do we?

The test was copied 1 to 1 from the original location
\Symfony\Bundle\FrameworkBundle\Tests\DependencyInjection\Compiler\AddConsoleCommandPassTest::testHttpKernelRegisterCommandsIngoreCommandAsAService.

Any suggestions how to name the testcase instead?

Imo this test case should have never lived here. It actually does not test test compiler pass, but the bundle class from the HttpKernel component and therefore should live there.

xabbuh · 2016-10-14T12:54:18Z

src/Symfony/Bundle/FrameworkBundle/DependencyInjection/Compiler/AddConsoleCommandPass.php

 *
 * @author Grégoire Pineau <[email protected]>
+ *
+ * @deprecated since version 3.2, to be removed in 4.0. Use Symfony\Component\Console\DependencyInjection\AddConsoleCommandPass instead.
 */
 class AddConsoleCommandPass implements CompilerPassInterface


Wouldn't it be better to let this class extend the new compiler pass instead of having to maintain the same code twice?

This would introduce a new dependency symfony/console to symfony/framework-bundle that is not yet defined in composer.json.

Should the new dependency be added to composer.json or can should this fail during runtime?

We could add a conflict rule for versions of the Console component before 3.2.

xabbuh · 2016-10-18T06:55:18Z

src/Symfony/Bundle/FrameworkBundle/DependencyInjection/Compiler/AddConsoleCommandPass.php

@@ -11,14 +11,18 @@

 namespace Symfony\Bundle\FrameworkBundle\DependencyInjection\Compiler;

+@trigger_error(sprintf('%s is deprecated as of 3.2 and will be removed in 4.0. Use Symfony\Component\Console\DependencyInjection\AddConsoleCommandPass instead.', AddConsoleCommandPass::class), E_USER_DEPRECATED);


[...] deprecated since version 3.2 [...]

xabbuh · 2016-10-22T08:05:41Z

👍 (failure is unrelated)

Status: Reviewed

ro0NL · 2016-10-22T12:21:34Z

Should we make some hardcoded id's / strings configurable thru required constructor args, as done in #20250? See discussion: #20250 (comment)

…l component (xabbuh) This PR was merged into the 2.7 branch. Discussion ---------- [FrameworkBundle][HttpKernel] move test to the HttpKernel component | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #19443 (comment) | License | MIT | Doc PR | The moved test case does not test the `AddConsoleCommandPass` class, but ensures certain behavior in the `registerCommands()` method of the `Bundle` class from the HttpKernel component. Commits ------- c9ca322 move test to the HttpKernel component

bcremer · 2017-01-11T07:16:12Z

Is there still anything I can help to get this merged into 3.3?

xabbuh · 2017-01-11T10:48:38Z

@bcremer You rebase this once again to resolve conflicts, but otherwise this looks ready to me.

ping @symfony/deciders

xabbuh · 2017-01-11T10:49:24Z

UPGRADE-3.2.md

@@ -27,6 +27,7 @@ FrameworkBundle
 * The `Resources/public/images/*` files have been removed.
 * The `Resources/public/css/*.css` files have been removed (they are now inlined
   in TwigBundle).
+ * The `Symfony\Bundle\FrameworkBundle\DependencyInjection\Compiler\AddConsoleCommandPass` has been deprecated. Use `Symfony\Component\Console\DependencyInjection\AddConsoleCommandPass` instead.


Ah sorry, now that Symfony 3.2 is released we would need to move this to the UPGRADE-3.2md file and update deprecation messages accordingly.

bcremer · 2017-01-11T12:19:00Z

@xabbuh Rebased onto master and targeted to Symfony 3.3.

fabpot · 2017-01-11T18:30:34Z

Thank you @bcremer.

…dle to Console. (bcremer) This PR was merged into the 3.3-dev branch. Discussion ---------- [Console] Move AddConsoleCommandPass from FrameworkBundle to Console. | Q | A | | --- | --- | | Branch? | master | | Bug fix? | no | | New feature? | yes | | BC breaks? | yes | | Deprecations? | yes | | Tests pass? | yes | | Fixed tickets | #19440 | | License | MIT | | Doc PR | - | Commits ------- 7743989 Move AddConsoleCommandPass from FrameworkBundle to Console.

…ent isn't installed (dunglas) This PR was merged into the 3.3-dev branch. Discussion ---------- [FrameworkBundle] Prevent an error when the console component isn't installed | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #21246 | License | MIT | Doc PR |n/a Finish #19443. Alternative to #21246. Commits ------- ab133ca [FrameworkBundle] Prevent an error when the console component isn't installed

…onent (chalasr) This PR was merged into the 3.3-dev branch. Discussion ---------- [Form][FrameworkBundle] Move FormPass to the Form component | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a So that anyone using only Form and DI can use it for registering form types/type guessers. Follows #19443, related to #21284 Commits ------- e68a6d9 [FrameworkBundle][Form] Move FormPass to the Form component

bcremer force-pushed the move-AddConsoleCommandPass branch from c2deecc to dffd5e6 Compare July 27, 2016 09:45

dunglas reviewed Jul 27, 2016
View reviewed changes

bcremer force-pushed the move-AddConsoleCommandPass branch from b6f8cc5 to 94a19f3 Compare July 28, 2016 05:51

nicolas-grekas reviewed Jul 28, 2016
View reviewed changes

bcremer force-pushed the move-AddConsoleCommandPass branch from 94a19f3 to 1094537 Compare July 28, 2016 07:28

nicolas-grekas reviewed Jul 28, 2016
View reviewed changes

bcremer force-pushed the move-AddConsoleCommandPass branch from 1094537 to 17385a7 Compare July 28, 2016 08:04

stof reviewed Jul 28, 2016
View reviewed changes

bcremer force-pushed the move-AddConsoleCommandPass branch from 17385a7 to 6e57865 Compare July 28, 2016 12:33

bcremer changed the title ~~Move AddConsoleCommandPass from FrameworkBundle to Console.~~ [Console] Move AddConsoleCommandPass from FrameworkBundle to Console. Jul 29, 2016

javiereguiluz added the Console label Aug 4, 2016

bcremer force-pushed the move-AddConsoleCommandPass branch from 6e57865 to db03053 Compare September 15, 2016 05:22

xabbuh reviewed Oct 14, 2016

View reviewed changes

bcremer force-pushed the move-AddConsoleCommandPass branch from 014c9eb to cf946c9 Compare October 17, 2016 12:39

xabbuh reviewed Oct 18, 2016

View reviewed changes

bcremer force-pushed the move-AddConsoleCommandPass branch from cf946c9 to e7f2763 Compare October 21, 2016 08:31

carsonbot added the Status: Reviewed label Oct 22, 2016

xabbuh mentioned this pull request Oct 22, 2016

[FrameworkBundle][HttpKernel] move test to the HttpKernel component #20273

Merged

javiereguiluz added this to the 3.3 milestone Nov 7, 2016

xabbuh reviewed Jan 11, 2017

View reviewed changes

bcremer force-pushed the move-AddConsoleCommandPass branch from e7f2763 to 4928c24 Compare January 11, 2017 12:04

Move AddConsoleCommandPass from FrameworkBundle to Console.

7743989

bcremer force-pushed the move-AddConsoleCommandPass branch from 4928c24 to 7743989 Compare January 11, 2017 12:05

fabpot merged commit 7743989 into symfony:master Jan 11, 2017

bcremer deleted the move-AddConsoleCommandPass branch January 12, 2017 06:26

dunglas mentioned this pull request Jan 12, 2017

[FrameworkBundle] Prevent an error when the console component isn't installed #21248

Merged

This was referenced Jan 13, 2017

[Form][FrameworkBundle] Move FormPass to the Form component #21283

Merged

[FrameworkBundle] Move compiler passes to their component #21284

Closed

chalasr mentioned this pull request Jan 21, 2017

[FrameworkBundle][WebProfilerBundle] Move ProfilerPass to the WebProfiler bundle #21368

Closed

nicolas-grekas modified the milestones: 3.x, 3.3 Mar 24, 2017

fabpot mentioned this pull request May 1, 2017

Release v3.3.0-BETA1 #22603

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Console] Move AddConsoleCommandPass from FrameworkBundle to Console. #19443

[Console] Move AddConsoleCommandPass from FrameworkBundle to Console. #19443

bcremer commented Jul 27, 2016 •

edited

Loading

mcfedr commented Jul 27, 2016

dunglas Jul 27, 2016

bcremer Jul 28, 2016

nicolas-grekas Jul 28, 2016

bcremer Jul 28, 2016

nicolas-grekas Jul 28, 2016

stof Jul 28, 2016

bcremer Jul 28, 2016

fabpot commented Sep 14, 2016

bcremer commented Sep 15, 2016

xabbuh Oct 14, 2016

xabbuh Oct 14, 2016

bcremer Oct 17, 2016

xabbuh Oct 18, 2016

xabbuh Oct 22, 2016

xabbuh Oct 14, 2016

bcremer Oct 17, 2016

xabbuh Oct 18, 2016

xabbuh Oct 18, 2016

xabbuh commented Oct 22, 2016

ro0NL commented Oct 22, 2016

bcremer commented Jan 11, 2017

xabbuh commented Jan 11, 2017

xabbuh Jan 11, 2017

bcremer commented Jan 11, 2017 •

edited

Loading

fabpot commented Jan 11, 2017

		@@ -11,13 +11,17 @@

		namespace Symfony\Bundle\FrameworkBundle\DependencyInjection\Compiler;

		@trigger_error(sprintf('%s is deprecated as of 3.2 and will be removed in 4.0. Use Symfony\Component\Console\DependencyInjection\AddConsoleCommandPass instead.', __CLASS__), E_USER_DEPRECATED);

		@@ -11,14 +11,18 @@

		namespace Symfony\Bundle\FrameworkBundle\DependencyInjection\Compiler;

		@trigger_error(sprintf('%s is deprecated as of 3.2 and will be removed in 4.0. Use Symfony\Component\Console\DependencyInjection\AddConsoleCommandPass instead.', AddConsoleCommandPass::class), E_USER_DEPRECATED);

[Console] Move AddConsoleCommandPass from FrameworkBundle to Console. #19443

[Console] Move AddConsoleCommandPass from FrameworkBundle to Console. #19443

Conversation

bcremer commented Jul 27, 2016 • edited Loading

mcfedr commented Jul 27, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fabpot commented Sep 14, 2016

bcremer commented Sep 15, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

xabbuh commented Oct 22, 2016

ro0NL commented Oct 22, 2016

bcremer commented Jan 11, 2017

xabbuh commented Jan 11, 2017

Choose a reason for hiding this comment

bcremer commented Jan 11, 2017 • edited Loading

fabpot commented Jan 11, 2017

bcremer commented Jul 27, 2016 •

edited

Loading

bcremer commented Jan 11, 2017 •

edited

Loading