Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Finder] no PHP warning on empty directory iteration #19636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

[Finder] no PHP warning on empty directory iteration #19636

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2eea1df
UPDATE check if path is set to prevent warning on empty directory
ggottwald Aug 16, 2016
26906de
UPDATE check if path is set to prevent warning on empty directory
ggottwald Aug 16, 2016
46fde82
UPDATE using yoda condition
ggottwald Sep 7, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
UPDATE check if path is set to prevent warning on empty directory
  • Loading branch information
@ggottwald
ggottwald committed Aug 16, 2016
commit 2eea1df4d50c8c1ef4c8e917ec6d5988ecd78945
4 changes: 4 additions & 0 deletions src/Symfony/Component/Finder/Iterator/RecursiveDirectoryIterator.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,10 @@ public function isRewindable()
return $this->rewindable;
}

if (empty($this->getPath())) {
return $this->rewindable = false;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A test should probably be added to cover this scenario


if (false !== $stream = @opendir($this->getPath())) {
$infos = stream_get_meta_data($stream);
closedir($stream);
Expand Down