[Validator] Used "::class" name resolution instead of "__NAMESPACE__" constant #19692
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…PACE__" magic constant The obscurity of building full Constraint class names by concatenating strings is therefore removed. This could make it easier for some IDEs or other static analysis tools to identify usages of that specific class. More details about "::class": http://php.net/manual/en/language.oop5.basic.php#language.oop5.basic.class.class
|
duplicates #17420 |
|
@Koc Hmmm, did not see that PR. I'm surprised to see that it was closed instead of merged. The |
|
@SoboLAN because it would cause problems merging upstream changes for 2.7 and 2.8 |
|
👍 clean syntax / ide support. Upstream merge conflicts are overrated. This hardly ever changes. |
|
We all agree that this syntax is better, and that's why we use it since 3.0 for new features. But for 2.7/2.8, the regular merges of 2.8 into 3.x would create merge conflicts during the whole lifetime of the 2.8 version, which means many years since it's an LTS. That's why we already refused this and we must stick to this policy. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The obscurity of building full Constraint class names by concatenating strings is removed. This could make it easier for some IDEs or other static analysis tools to identify usages of that specific class.
More details about "::class": http://php.net/manual/en/language.oop5.basic.php#language.oop5.basic.class.class
PS: It could be a good idea to apply this throughout the code, not just in Validator Component.