Profiler exception and test #197
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and filling in some missing tests
|
If something is weird, we can probably talk about it and see if needs to be changed. Anyway, I've merged this patch. |
SofHad
pushed a commit
to SofHad/symfony
that referenced
this pull request
Oct 12, 2015
This PR was squashed before being merged into the master branch (closes symfony#197). Discussion ---------- CodeExplorerBundle Very simple implementation, without any overheads and overkills :) See symfony/demo#196 Commits ------- aaa71e9 CodeExplorerBundle
jderusse
pushed a commit
to jderusse/symfony
that referenced
this pull request
Mar 30, 2020
fix typo3/cms branches/version for two advisories
chalasr
pushed a commit
to chalasr/symfony
that referenced
this pull request
Sep 24, 2020
Add a "sponsor" button to save the panthers
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey guys-
This is an existing feature that works and this proposes no changes. This simply adds an exception if a
data_collectoris specified with a "template" key, but no "id" key. Previously, it would silently skip these entries. Now it throws an exception.I also added some missing tests. The format of some of the config values seem odd, but I'm assuming this feature is working, so the tests match that reality.
Thanks!