Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Security] $attributes can be anything, but RoleVoter assumes strings #19725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 6, 2016
Merged

[Security] $attributes can be anything, but RoleVoter assumes strings #19725

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/Symfony/Component/Security/Core/Authorization/Voter/RoleVoter.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
namespace Symfony\Component\Security\Core\Authorization\Voter;

use Symfony\Component\Security\Core\Authentication\Token\TokenInterface;
use Symfony\Component\Security\Core\Role\RoleInterface;

/**
* RoleVoter votes if any attribute starts with a given prefix.
Expand All @@ -37,7 +38,7 @@ public function __construct($prefix = 'ROLE_')
*/
public function supportsAttribute($attribute)
{
return 0 === strpos($attribute, $this->prefix);
return is_string($attribute) && 0 === strpos($attribute, $this->prefix);
}

/**
Expand All @@ -57,6 +58,10 @@ public function vote(TokenInterface $token, $object, array $attributes)
$roles = $this->extractRoles($token);

foreach ($attributes as $attribute) {
if ($attribute instanceof RoleInterface) {
$attribute = $attribute->getRole();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should not call supportAttribute if the return value of getRole() is null as it means that there is no good representation of the role as a string.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nevermind, that's already covered in supportsAttribute() via the is_string() check.

}

if (!$this->supportsAttribute($attribute)) {
continue;
}
Expand Down
6 changes: 6 additions & 0 deletions src/Symfony/Component/Security/Core/Tests/Authorization/Voter/RoleVoterTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,12 @@ public function getVoteTests()
array(array('ROLE_FOO'), array('ROLE_FOO'), VoterInterface::ACCESS_GRANTED),
array(array('ROLE_FOO'), array('FOO', 'ROLE_FOO'), VoterInterface::ACCESS_GRANTED),
array(array('ROLE_BAR', 'ROLE_FOO'), array('ROLE_FOO'), VoterInterface::ACCESS_GRANTED),

// Test mixed Types
array(array(), array(array()), VoterInterface::ACCESS_ABSTAIN),
array(array(), array(new \stdClass()), VoterInterface::ACCESS_ABSTAIN),
array(array('ROLE_BAR'), array(new Role('ROLE_BAR')), VoterInterface::ACCESS_GRANTED),
array(array('ROLE_BAR'), array(new Role('ROLE_FOO')), VoterInterface::ACCESS_DENIED),
);
}

Expand Down