Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Security] $attributes can be anything, but RoleVoter assumes strings #19726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[Security] $attributes can be anything, but RoleVoter assumes strings #19726

wants to merge 1 commit into from

Conversation

maennchen
Copy link

@maennchen maennchen commented Aug 24, 2016

Q A
Branch? 3.0
Bug fix? yes
New feature? no
BC breaks? yes
Deprecations? no
Tests pass? yes
Fixed tickets #18042
License MIT
Doc PR reference to the documentation PR, if any

This is the merged to 3.0 version of #19725.

@lemoinem
Copy link
Contributor

Hello, Thank you but unless there are merge conflicts, your PR on 2.7 will be automatically merged in every supported branches, including 3.0, 3.1 and master...

From what I can see, the patch are completely equivalent, so I don't think you need this PR.

Thank you for the hard work!

@maennchen
Copy link
Author

@lemoinem Since the method supportsAttribute does not exist anymore in newer branches, there will be a merge conflict. This would be the solution to that merge conflict.

@lemoinem
Copy link
Contributor

Ok, I see the difference now.
Status: Reviewed (Dependent on #19725, of course)

@nicolas-grekas
Copy link
Member

Can you rebase+change the base branch to 3.1 so that tests are against 3.1? 3.0 is not maintained anymore.

@maennchen
Copy link
Author

@nicolas-grekas Won't you merge the changes into 2.7 (#19725) ? Then you will encounter the merge error starting with the 3.0 version. This PR is just to fix the merge error.

If you want to only apply starting from 2.7, leave a gap and restart at 3.1, I will rebase it.

@fabpot fabpot closed this Oct 6, 2016
@maennchen maennchen deleted the hotfix/18042_support_mixed_types_3.0 branch October 6, 2016 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants