Visibility changes #198
Visibility changes #198
Conversation
|
Please no private methods and attributes. Symfony2 always uses public or protected visibility. Private visibility uses only in extraordinary cases. In my opinion, this is a sensible solution. In Python or Ruby there is no real private visibility. Symfony2 is framework and so each class should be extensible and each method should be reusable. |
|
What's the reasoning behind renaming account to user? Account is probably semantically more correct. A user can have more than one account. A user cannot be disabled, an account can. And it seems to me that account is understandable by everyone. |
|
I definitely don't like UserDetails. UserAccountInterface seems better to me, but the, I still like AccountInterface better. |
- visibility changes from protected to private - AccountInterface -> UserInterface - SecurityContext::vote() -> SecurityContext::isGranted()
|
I'm wondering do we still need has_role? Isn't the app.security.vote recommended way to check for permissions? |
…(ccab) This PR was squashed before being merged into the master branch (closes symfony#201). Discussion ---------- Adding translation config to pagination controls Fixed symfony#198 Commits ------- f060e90 Adding translation config to pagination controls
shopware january 2017 advisory
Update composer.json
This commit has mostly visibility changes plus some method changes, see the commit message.