[WebProfilerBundle] Fix margin on toolbar route panel when no route is found in the request #19812
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This makes the redirection/forward icon to be closer to the status panel than before ... but it's probably OK:
|
|
Maybe the better solution is to wrap up the optionally displayed SVG and the other elements representing the route in a single element that has the |
|
We're always cautious about modifying the HTML structure ... so maybe the following would suffice: .sf-toolbar-block-request .sf-toolbar-status + svg {
margin-left: 5px;
} |
When no route was found (404) then the route panel margin would cause unnecessary space between the status panel and the response time panel.
be08d76 to
7fdffd1
Compare
|
Updated, that fixes both scenarios :) |
|
Thank you @jameshalsall. |
fabpot
added a commit
that referenced
this pull request
Sep 1, 2016
… no route is found in the request (jameshalsall) This PR was merged into the 3.1 branch. Discussion ---------- [WebProfilerBundle] Fix margin on toolbar route panel when no route is found in the request | Q | A | ------------- | --- | Branch? | 3.1 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #19805 | License | MIT Just to clarify, this bug was introduced in the 3.1 release when some of the toolbar was re-structured Commits ------- 7fdffd1 [WebProfilerBundle] Fix margin on toolbar route panel.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just to clarify, this bug was introduced in the 3.1 release when some of the toolbar was re-structured